shared_ptr has arrived to the standard. NFC

[vgvassilev]

We replace the CPP11_shared_ptr macro with its actual expansion to
std::shared_ptr nowadays.

We replace the inclusion of <CPP11_shared_ptr.hh> with and order
the includes from less generic to generic ones where applicable.

Depends on: #27626

cc @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27625/11110

• This PR adds an extra 72KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File JetMETCorrections/FFTJetModules/interface/FFTJetESParameterParser.h modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetModules/plugins/FFTJetCorrectorDBReader.cc modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetModules/plugins/FFTJetLookupTableESProducer.cc modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetObjects/interface/AbsFFTJetScaleCalculator.h modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetObjects/interface/FFTJetScaleCalculators.h modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetObjects/src/loadFFTJetInterpolationTable.cc modified in PR(s): shared_ptr has arrived to the standard. NFC #27626

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27625/11110/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27625/11110/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[vgvassilev]

I do not think it makes sense to apply what the bot proposed.

[davidlange6]

@fabiocos - is it possible that clang-format has not been run on Alignment/Geners/interface/ArchiveRecord.hh? (which does not follow the right naming convention)

[davidlange6]

never mind - I realize its easy to answer my own question - clang-format has indeed not been run on this file for some reason (perhaps its name). @vgvassilev - the patch is basically orthogonal to your work, its just that you touched a file that eluded the clang-format migration

[smuzaffar]

@davidlange6 , code-format was not run on this file as this file is not used by any thing. @vgvassilev I would suggest to just drop this file.

[vgvassilev]

Done.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27625/11277

• This PR adds an extra 72KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File JetMETCorrections/FFTJetModules/interface/FFTJetESParameterParser.h modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetModules/plugins/FFTJetCorrectorDBReader.cc modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetModules/plugins/FFTJetLookupTableESProducer.cc modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetObjects/interface/AbsFFTJetScaleCalculator.h modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetObjects/interface/FFTJetScaleCalculators.h modified in PR(s): shared_ptr has arrived to the standard. NFC #27626
  • File JetMETCorrections/FFTJetObjects/src/loadFFTJetInterpolationTable.cc modified in PR(s): shared_ptr has arrived to the standard. NFC #27626

[cmsbuild]

Pull request #27625 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun, @santocch can you please check and sign again.

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1859/console Started: 2019/08/06 20:43

[cmsbuild]

+1
Tested at: 393a554
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0486aa/1859/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0486aa/1859/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 2715989
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2715658
• DQMHistoTests: Total skipped: 329
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[pohsun]

+1

[fabiocos]

+1

@santocch the PR looks ok to me, please have a look

[fabiocos]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.