-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bx skim and corresponding RelVal #26476
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26476/9323
|
A new Pull Request was created by @kfjack (Kai-Feng Chen) for master. It involves the following packages: Configuration/PyReleaseValidation @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 136.899,136.900 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
Hi all, it seems that I cannot remove RECO steps from the relval (the comparison cannot be performed), even it is not really needed for this special skim. Will try to add them back and see if it is functioning... |
The tests are being triggered in jenkins. |
-1 Tested at: 53ac3e6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/136.899_RunHLTPhy2018E+RunHLTPhy2018E+HLTDR2_2018+RECODR2_2018reHLT_skimHLTPhy_Prompt+HARVEST2018_Prompt/step3_RunHLTPhy2018E+RunHLTPhy2018E+HLTDR2_2018+RECODR2_2018reHLT_skimHLTPhy_Prompt+HARVEST2018_Prompt.log136.9 step3 runTheMatrix-results/136.9_RunZeroBias2018E+RunZeroBias2018E+HLTDR2_2018+RECODR2_2018reHLT_skimZeroBias_Prompt+HARVEST2018_Prompt/step3_RunZeroBias2018E+RunZeroBias2018E+HLTDR2_2018+RECODR2_2018reHLT_skimZeroBias_Prompt+HARVEST2018_Prompt.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
For future reference, the error is:
It could take significant work to make the full RECO step cooperate with this special scenario. To make comparison plots, really it's the DQM step that is needed, but I doubt this can run easily without the preceding RECO step. If there is sufficient interest in studying the data from these runs, we can try to introduce a specific Modifier like run2_2018_highPU, in order to remove/modify pieces of the RECO step that don't work. But I am not sure exactly how much work this would take. |
@kfjack what is the plan about this PR? Is there activity, or it can be just closed for the time being? |
Hi @fabiocos I think we shall close this PR for the time being as well. If all agree I'll close it. |
PR description:
This PR includes the proposal of BunchCrossingSkim PR #26419 and the corresponding updates for RelVal. This is for the master branch.
PR validation:
RelVal workflows are added to 2018E HLTPhy and ZeroBias. Given the special situation of the BunchCrossingSkim the RelVal has only SKIM part, without RECO and other steps.
The corresponding workflows are
136.899
136.900