-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Phase2 workflows #27449
Clean up Phase2 workflows #27449
Conversation
…ertain subdetector versions
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27449/10761
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: Configuration/Geometry @cmsbuild, @prebello, @Dr15Jones, @cvuosalo, @civanch, @ianna, @mdhildreth, @pgunnell, @franzoni, @kpedro88, @zhenhu, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 72c1b09 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44/step1_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D44+RecoFullGlobal_2023D44+HARVESTFullGlobal_2023D44.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
+1 |
+operations the update to Configuration is coherent with the purpose of the PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Resolves #26938.
Outdated Phase2 subdetectors, detectors, and workflows are removed. A now-unnecessary special workflow is also removed (the "Timing" option, since all supported workflows now include MTD + use of timing in reco).
The number of places to edit in order to add new workflows is reduced by automating the deepcopy for PU workflows and the initialization of default datasets.
Two new workflows are added to keep alive the T15 tracker and the HF nose, since the previous workflows with those subdetectors used now-unsupported versions of other subdetectors.
Workflow numbers are reset and the short matrix is updated accordingly. (This will cause spurious comparison differences.)
The 2023 -> 2026 renaming will come in a subsequent PR, because this one is already huge and that one will also be huge.
PR validation:
Tested that runTheMatrix works correctly.