Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of wf 20434.1 after Phase2 relval updates #27507

Closed
fabiocos opened this issue Jul 12, 2019 · 12 comments
Closed

Failure of wf 20434.1 after Phase2 relval updates #27507

fabiocos opened this issue Jul 12, 2019 · 12 comments

Comments

@fabiocos
Copy link
Contributor

After #27449 that has update the Phase2 relval sets in the matrix, test wf 20434.1 fails in a reproducible way. This is a D41 scenario workflow with the trackingOnly sequence, previously running in scenario D17, and it looks like the sequence is not yet adapted to the MTD inclusion:

----- Begin Fatal Exception 12-Jul-2019 11:15:54 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 2 event: 104 stream: 2
   [1] Running path 'RECOSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'RECOSIMoutput'
   [3] Prefetching for module RecoChargedRefCandidatePrimaryVertexSorter/'offlinePrimaryVertices4D'
   [4] Prefetching for module ChargedRefCandidateProducer/'trackRefsForJetsBeforeSorting4D'
   [5] Prefetching for module TrackWithVertexRefSelector/'trackWithVertexRefSelectorBeforeSorting4D'
   [6] Prefetching for module PrimaryVertexProducer/'unsortedOfflinePrimaryVertices4D'
   [7] Prefetching for module TOFPIDProducer/'tofPID'
   [8] Calling method for module PrimaryVertexProducer/'unsortedOfflinePrimaryVertices4DnoPID'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap<float>
Looking for module label: trackExtenderWithMTD
Looking for productInstanceName: generalTracksigmat0

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
@cmsbuild
Copy link
Contributor

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

assign reconstruction,upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade,reconstruction

@slava77,@perrotta,@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kpedro88
Copy link
Contributor

@fabiocos
Copy link
Contributor Author

fabiocos commented Jul 14, 2019

The sequence reconstruction_trackingOnly is based on globalreco_tracking https://cmssdt.cern.ch/lxr/source/Configuration/StandardSequences/python/Reconstruction_cff.py#0106 which does not include the module trackExtenderWithMTD, added at the end of globalreco as fastTimingGlobalReco

process.globalreco = cms.Sequence(process.globalreco_tracking+process.particleFlowCluster+process.ecalClusters+process.caloTowersRec+process.egammaGlobalReco+process.jetGlobalReco+process.muonGlobalReco+process.pfTrackingGlobalReco+process.muoncosmicreco+process.fastTimingGlobalReco)

in https://cmssdt.cern.ch/lxr/source/Configuration/StandardSequences/python/Reconstruction_cff.py#0141

@fabiocos
Copy link
Contributor Author

the addition of

 
+_phase2_timing_layer_globalreco_tracking = globalreco_tracking.copy()
+_phase2_timing_layer_globalreco_tracking += fastTimingGlobalReco
+(phase2_timing_layer_tile | phase2_timing_layer_bar).toReplaceWith(globalreco_tracking,_phase2_timing_layer_globalreco_tracking)

to Reconstruction_cff.py seems to be enough to prevent the failure

@mtosi
Copy link
Contributor

mtosi commented Jul 15, 2019

thanks !

@kpedro88
Copy link
Contributor

Will someone open a PR with the suggestion from @fabiocos? I can also do it, but don't want to duplicate effort

@perrotta
Copy link
Contributor

perrotta commented Jul 16, 2019 via email

@kpedro88
Copy link
Contributor

+upgrade

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants