MTV phase2 high eta

[mtosi]

PR description:

as discussed w/ the TK Phase2 Simulation group (@emiglior @pieterdavid)
the current selection based on the pT of the tracking particle used in the MTV
distorts the momentum spectrum of tracks, because of the Phase2 acceptance is upto |eta| = 4
(a track w/ pT=0.9 GeV at eta = 0.1 has p= 0.9045 GeV, while at eta=3 has p=9.0609 GeV)
therefore, it is useful to add an extra category in the MTV for the Phase2 workflow
meant to validate the tracks at high eta
and given the tracker phase2 geometry we define it as |eta| > 2.7

the current selector for tracking particles, gen particles and tracks
is designed for applying the selection on the pseudo-rapidity,
but it expects it to be w/in the min and max values

in this PR

• an extra boolean parameter is added,
  in order to handle the switch of the selection from inside a given range to outside
• the possibility of selecting a range in phi is added (when missing)
• the extra category trackValidatorTPEtaGreater2p7 is added to Validation/RecoTrack/python/TrackValidation_cff.py

PR validation:

runTheMatrix.py -w upgrade -l 20424.1
runTheMatrix.py -l limited -i all --ibeos

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27653/11189

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/RecoTrack/plugins/MultiTrackValidator.cc modified in PR(s): MTV protection for samples without jets info #27611
  • File Validation/RecoTrack/python/TrackValidation_cff.py modified in PR(s): MTV : add chi2_vs_pt, assoc_chi2_vs_pt and assoc_chi2prob_vs_pt #27345
  • File Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc modified in PR(s): MTV : add chi2_vs_pt, assoc_chi2_vs_pt and assoc_chi2prob_vs_pt #27345

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27653/11189/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27653/11189/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[pieterdavid]

@mtosi I think you meant to include @pwittich instead of me

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27653/11195

• This PR adds an extra 64KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/RecoTrack/plugins/MultiTrackValidator.cc modified in PR(s): MTV protection for samples without jets info #27611
  • File Validation/RecoTrack/python/TrackValidation_cff.py modified in PR(s): MTV : add chi2_vs_pt, assoc_chi2_vs_pt and assoc_chi2prob_vs_pt #27345
  • File Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc modified in PR(s): MTV : add chi2_vs_pt, assoc_chi2_vs_pt and assoc_chi2prob_vs_pt #27345

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

CommonTools/CandAlgos
CommonTools/RecoAlgos
SimTracker/Common
Validation/RecoTrack

@perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @pieterdavid, @jdolen, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @gbenelli, @jhgoh, @VinInn, @ahinzmann, @prolay, @gkasieczka, @rovere, @threus, @wmtford, @ebrondol, @mmusich, @dgulhan, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mtosi]

hold

sorry, but I'm still checking few things that I do not understand

1. workflows 20034.0, 20434.0 and 21234.0 produce the expected new directory
   Tracking/TrackTPPtGreater2p7/, while workflow 20424.0 does not produce it
2. the distribution of eta is only negative

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27653/11197

• This PR adds an extra 64KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/RecoTrack/plugins/MultiTrackValidator.cc modified in PR(s): MTV protection for samples without jets info #27611
  • File Validation/RecoTrack/python/TrackValidation_cff.py modified in PR(s): MTV : add chi2_vs_pt, assoc_chi2_vs_pt and assoc_chi2prob_vs_pt #27345
  • File Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc modified in PR(s): MTV : add chi2_vs_pt, assoc_chi2_vs_pt and assoc_chi2prob_vs_pt #27345

[santocch]

+1

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

please test
(just because it has been 2+ weeks since the last tests will run, will merge after these come back)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2244/console Started: 2019/08/28 22:39

[cmsbuild]

+1
Tested at: 65d0650
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6b0a9/2244/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6b0a9/2244/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939164
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 11908.251 KiB( 33 files compared)
• DQMHistoSizes: changed ( 20034.0,... ): 2495.389 KiB Tracking/TrackTPEtaGreater2p7
• DQMHistoSizes: changed ( 20034.0,... ): 50.531 KiB Tracking/Track
• DQMHistoSizes: changed ( 20034.0,... ): 9.715 KiB Tracking/TrackBuilding
• DQMHistoSizes: changed ( 20034.0,... ): 5.045 KiB Tracking/TrackFromPVAllTP
• DQMHistoSizes: changed ( 20034.0,... ): 4.986 KiB Tracking/TrackFromPV
• DQMHistoSizes: changed ( 20034.0,... ): 4.910 KiB Tracking/TrackConversion
• DQMHistoSizes: changed ( 20034.0,... ): 2.470 KiB Tracking/TrackAllTPEffic
• DQMHistoSizes: changed ( 20034.0,... ): 1.189 KiB Tracking/TrackGsf
• DQMHistoSizes: changed ( 20034.0,... ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 20034.0,... ): 0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 25.0 ): ...
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[kpedro88]

+1