Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCal] New fragments for special HGCal RelVal requests #27631

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

apsallid
Copy link
Contributor

PR description:

The HGCal DPG wants to regularly inspect the performance of CLUE clustering in 120/200/300/Scint regions, while at the same time study the 3D score and the behavior of the multicluster validation. For these reasons, we add new gen fragments and will later create a JIRA ticket with the relevant RelVal requests to the PdmV group. Two things to notice, as PdmV told us (@siddhesh86 ) :

  • Since separate workflows with unique numbers would be preferred as all the relvals can be submitted in one go, we have added the GEN fragments we wish to use.
  • In all cases we tried to stay with a name of low string length, since high string length names are not getting submitted lately.

Specifically, we are shooting in front of:

  • The scintillator part of CE-H Coarse.
  • The silicon part of CE-H Coarse.
  • CE-H Fine in the 3 different thicknesses of Silicon cells.
  • CE-E in the 3 different thicknesses of Silicon cells. 


PR validation:

We have used in the past the CloseByParticleGun with a pair of unconverted photons for calibration studies [1].

if this PR is a backport please specify the original PR:

This is not a backport.

@rovere @felicepantaleo @amartelli @gouskos @siddhesh86

[1] https://indico.cern.ch/event/813555/contributions/3400815/attachments/1831509/2999508/Psallidas-Checks.pdf

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27631/11124

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Configuration/Generator

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@apsallid you also need to modify the lists at the end of https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py so the workflow numbers will be assigned for these new fragments

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The code-checks are being triggered in jenkins.

@apsallid
Copy link
Contributor Author

apsallid commented Aug 1, 2019

@kpedro88 Thanks a lot. Sorry for this late reply, I was traveling today. These are difficult days.

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 1, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27631/11253

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1787/console Started: 2019/08/01 23:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

Pull request #27631 was updated. @cmsbuild, @prebello, @zhenhu, @efeyazgan, @kpedro88, @pgunnell, @agrohsje, @alberto-sanchez, @qliphy can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e27b52/1787/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2492470
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492152
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 2, 2019

+upgrade

@qliphy
Copy link
Contributor

qliphy commented Aug 2, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

@prebello @zhenhu the update to PyRelVal looks ok, I've managed to list the new test workflows and run 20494.0_CloseByParticleGun_CE_E_Front_300um+CE_E_Front_300um_2026D41_GenSimHLBeamSpotFull+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/ .

Could you please comment or sign it? I would like to move it forward

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Aug 5, 2019

merge

@prebello @zhenhu in case please comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants