-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCal] New fragments for special HGCal RelVal requests #27631
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27631/11124
|
A new Pull Request was created by @apsallid for master. It involves the following packages: Configuration/Generator @alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@apsallid you also need to modify the lists at the end of https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py so the workflow numbers will be assigned for these new fragments |
The code-checks are being triggered in jenkins. |
@kpedro88 Thanks a lot. Sorry for this late reply, I was traveling today. These are difficult days. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27631/11253
|
The tests are being triggered in jenkins. |
Pull request #27631 was updated. @cmsbuild, @prebello, @zhenhu, @efeyazgan, @kpedro88, @pgunnell, @agrohsje, @alberto-sanchez, @qliphy can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
@prebello @zhenhu the update to PyRelVal looks ok, I've managed to list the new test workflows and run Could you please comment or sign it? I would like to move it forward |
+1 |
PR description:
The HGCal DPG wants to regularly inspect the performance of CLUE clustering in 120/200/300/Scint regions, while at the same time study the 3D score and the behavior of the multicluster validation. For these reasons, we add new gen fragments and will later create a JIRA ticket with the relevant RelVal requests to the PdmV group. Two things to notice, as PdmV told us (@siddhesh86 ) :
Specifically, we are shooting in front of:
PR validation:
We have used in the past the CloseByParticleGun with a pair of unconverted photons for calibration studies [1].
if this PR is a backport please specify the original PR:
This is not a backport.
@rovere @felicepantaleo @amartelli @gouskos @siddhesh86
[1] https://indico.cern.ch/event/813555/contributions/3400815/attachments/1831509/2999508/Psallidas-Checks.pdf