Activate Simulation of the Pixel Bad Components on the FED channel basis

[mmusich]

PR description:

Based on the feedback received so far in https://its.cern.ch/jira/browse/PDMVRELVALS-30, the goal of this PR is to:

• switch on simulation of the Pixel Bad Components on the FED channel basis (a.k.a. stuck-TBM simulation)
• supply default payloads for the new record SiPixelStatusScenarioProbabilityRcd and SiPixelStatusScenariosRcd introduced in PR Simulation of the pixel bad components on the FED channel basis #25466, to all the phase-1 Global Tags.

As the SiPixelStatusScenario payload used in all the updated Global Tags contains (still) no bad components and the SiPixelStatusScenarioProbability payload defaults this "empty" scenario for all the PU bins, no changes in the physics outcome are expected from this PR, which then can be qualified as technical.
2017 and 2018 simulation Global Tags will be updated in a later time once appropriate conditions will be available.

PR validation:

The branch was tested via:

runTheMatrix.py -l limited -i all -j 8 --ibeos

and no failing workflows are observed: 32 31 30 24 12 2 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mmusich]

@tsusa FYI

[tocheng]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26275/8957

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33813/console Started: 2019/03/27 21:38

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/AlCa
SimGeneral/MixingModule

@civanch, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 23dad62
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26275/33813/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26275/33813/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8366 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 17436
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097196
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.534 KiB( 31 files compared)
• DQMHistoSizes: changed ( 7.3 ): 0.534 KiB SiStrip/MechanicalView
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[mmusich]

DQMHistoTests: Total failures: 17436

as expected changes affect only phase1 + run3 MC workflows and are all small and I think compatible with random fluctuations due to update of the digitizer sequence.

[tocheng]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33847/console Started: 2019/03/29 13:26

[cmsbuild]

+1
Tested at: 5ffe308
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26275/33847/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26275/33847/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8198 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3134059
• DQMHistoTests: Total failures: 14807
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3119053
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.891 KiB( 31 files compared)
• DQMHistoSizes: changed ( 250202.181 ): 0.064 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 0.831 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -0.004 KiB MessageLogger/Warnings
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[tocheng]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[fabiocos]

@tocheng @mmusich are the added new tags up to date? After their integration we have wf 10424.0 failing with the error

----- Begin Fatal Exception 02-Apr-2019 10:01:54 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module GEMDigiToRawModule/'gemPacker'
Exception Message:
No "GEMeMapRcd" record found in the EventSetup.n
 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Apparently GEMs are not included...

[mmusich]

@fabiocos not that this is of my concern as it has nothing to do with suck-TBM simulation, but I made the point with @tocheng about lots of spurious differences in the GT he provided:

$ conddb diff 106X_mc2017_design_IdealBS_v1 105X_mc2017_design_IdealBS_v6
[2019-04-02 10:16:19,069] INFO: Connecting to pro [frontier://PromptProd/CMS_CONDITIONS]
Record                               Label  pro::106X_mc2017_design_IdealBS_v1 Tag                    pro::105X_mc2017_design_IdealBS_v6 Tag   
-----------------------------------  -----  --------------------------------------------------------  ---------------------------------------  
GEMeMapRcd                           -      -                                                         GEMeMap_v1_mc                            
PFCalibrationRcd                     -      PFCalibration_v9_mc                                       PFCalibration_v10_mc                     
PFCalibrationRcd                     HLT    PFCalibration_HLT_2017_25ns_Spring17_V3_newCodeCompliant  PFCalibration_HLT_2018_25ns_Spring19_V1  
SiPixelStatusScenarioProbabilityRcd  -      SiPixelStatusScenarioProbabilities_default_v0_mc          -                                        
SiPixelStatusScenariosRcd            -      SiPixelFEDChannelContainer_Empty_mc                       -     

And he said this was OK.
I think AlCa should provide a fix.

[tocheng]

@fabiocos This is my bad. The issue is 2017 Ideal GT. Fixing now. To submit a PR soon.