[RFC] Add Pixel "Stuck TBM" simulation workflows to RelVal matrix

[mmusich]

Greetings,
this PR introduces (temporarily) 2018 MC workflows testing the Pixel Stuck TBM simulation (introduced recently in #25466) in the relval matrix.
As the feature is switched off by default and the necessary DB conditions are not (yet) available via autoCond, the activation flag and the conditions are supplied via customization of the DIGI step.
At the moment only the 2018 (noPU) case is treated as the conditions for the other cases (2017 and PU!=0) are still in the process of being derived.
cc @tsusa

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25524/7724

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32280/console Started: 2018/12/19 22:43

[cmsbuild]

+1
Tested at: 3ec49e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25524/32280/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25524/32280/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153511
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[prebello]

please test workflow 12424.0,12442.0

[cmsbuild]

+1
Tested at: 9de9934
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25524/32535/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25524/32535/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25524/10824.7_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25524/10842.7_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153512
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[zhenhu]

+1

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[makortel]

10824.7 is now failing in IBs for slc7_amd64_gcc820
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_10_5_X_2019-01-16-2300/pyRelValMatrixLogs/run/10842.7_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2018_GenSimFullINPUT+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2018_GenSimFullINPUT+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log#/65-65
and in DEVEL for slc7_amd64_gcc700
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc700/CMSSW_10_5_DEVEL_X_2019-01-16-2300/pyRelValMatrixLogs/run/10842.7_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2018_GenSimFullINPUT+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2018_GenSimFullINPUT+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log#/111-111

----- Begin Fatal Exception 17-Jan-2019 11:48:59 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 129 event: 12801 stream: 3
   [1] Running path 'digitisation_step'
   [2] Calling method for module MixingModule/'mix'
Exception Message:
A std::exception was thrown.
_Map_base::at
----- End Fatal Exception -------------------------------------------------

I'm taking a closer look.

[mmusich]

@makortel
Hi Matti, thanks for taking a look. In the meanwhile I realized that the conditions I used specifically for this test are not 100% matching, i.e. there are some non-zero probabilities (in SiPixelStatusScenarioProbabilityRcd) assigned to certain scenarios which are not included in the scenario DB object (SiPixelStatusScenariosRcd). We'll have to update the condition to make it work correctly, and probably throw in a more graceful way when one attempts to use mismatching conditions.

[makortel]

Hi Matti, thanks for taking a look. In the meanwhile I realized that the conditions I used specifically for this test are not 100% matching, i.e. there are some non-zero probabilities (in SiPixelStatusScenarioProbabilityRcd) assigned to certain scenarios which are not included in the scenario DB object (SiPixelStatusScenariosRcd). We'll have to update the condition to make it work correctly, and probably throw in a more graceful way when one attempts to use mismatching conditions.

@mmusich Thanks for the quick reply! I'll let you fix the conditions then.