-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status of testing of Apache Airflow 2.7.1rc2 #34065
Comments
hi @ephraimbuddy , wondering why #33039 is part of Airflow RC? I think it went in the Sqoop provider, no? |
It's because of conflict resolution, trying to cherry-pick cleanly. We had many refactoring PRs that addressed issues across core and providers. If you look at the description on the sync PR: #33826 I mentioned about provider changes getting cherry-picked to core. |
I encountered an issue when upgrading to 2.7.1rc1, linked to the pydantic upgrade. Do I open a seperate issue for this or can this be discussed here? Because of this, we are unable to upgrade our airflow version |
Check on fresh Airflow 2.7.1.rc1
|
Ops. Looks like we don't currently have great expectation in our codebase but would like to hear what others think cc @potiuk |
I encountered an issue when upgrading to 2.7.1rc1, linked to the pydantic
upgrade. Do I open a seperate issue for this or can this be discussed here?
Great expectations does not yet support pydantic > 2.0:
great-expectations/great_expectations#8604
<great-expectations/great_expectations#8604>
Airflow doesn't have an official integration/support for great
expectations, so if great expectations doesn't support pydantic v2 which we
use in 2.7.1, IMHO this should not be considered a breaking change.
…On Mon, Sep 4, 2023 at 5:28 PM Andrey Anshin ***@***.***> wrote:
Check on fresh Airflow 2.7.1.rc1
- #33672 <#33672> - Less
intensive queries to DB. Shorter execution time, less traffic between
backend and Airflow
- #33503 <#33503> - Seems
working with Postgres/MySQL as expected
- #33535 <#33535> - Work as
expected in the UI
—
Reply to this email directly, view it on GitHub
<#34065 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFCS775S3YTSFWWQA7LUH6LXYXXQLANCNFSM6AAAAAA4J6KWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Not a breaking change but great expectation is widely used, I think we should consider it |
My only concern is that pydantic v2 was added to fix a bug or just an improvement? if not maybe we should move it to 2.8.0 |
Yeah, I think it's for improvement |
Specifically for AIP-44 so yes ww move it down to v1 and we will release for 2.8.0 (when I hope AIP-44 will be ready to ship). By then Pydantic 2 should be much more widespread. |
hi,
As noted in comment #34065 (comment), Thank you for including all of these 🙏🏽 |
Hi,
|
Confirmed all my changes are in.! Looks good. |
+1. Checked my changes from RC1 (#34065 (comment)) are included here too and all work fine. |
Confirmed that #33478 is fixed |
Confirmed #32731 is fixed in RC1 |
I have pulled the 2.7.1rc2 commit and verified the following fixes in Breeze: #33735 is a docs-only fix and should be fine. I'm trying to verify #33632 but running into issues triggering the permissions sync (this issue might predate this release?) I will keep investigating and confirm. Update: I have found some issues preventing #33632 from working as expected. I will work on a fix and provide updates in #34114, but in the meantime we could also remove this commit from the release and save it for 2.7.2? I will leave it up to you. |
good for me |
Also tested #33424 |
Checked #33141 and can confirm it is working. Found a minor "glitch" of string formatting as we forked code of Flask-AppBuilder (manager.py) into the Airflow repo and the Flask Appbuilder has changed the string formatting upstream, the constants we source in manager.py:499 for example are now printed with |
Airflow 2.7.1 is now released. Thank you all for testing this release |
@jens-scheffler-bosch could you check if #34139 fix the bug you are talking about? |
Perfect. Yes. that was what I was referring to. Did not find the issue by search... so fixed already, GREAT! |
Body
We are kindly requesting that contributors to Apache Airflow RC 2.7.1rc1 help test the RC.
Please let us know by commenting if the issue is addressed in the latest RC.
expand_kwargs
method (#32272): @Talvarenga @hussein-awalaLinked issues:
Linked issues:
Linked issues:
orm_mode
rename (#33220): @ephraimbuddytag in Provider's view (#33326): @eladkal @pankajkoti
Linked issues:
processor_subdir
(#33357): @pierrejeambrunLinked issues:
CronTriggerTimetable
(#32921)Linked issues:
Linked issues:
conf.set
case insensitive (#33452): @vandonr-amzformatDuration
method (#33486): @hussein-awaladialect.name
in custom SA types (#33503): @agomez-etsy @TaragolisLinked issues:
Linked issues:
execution_date
parameter is malformed (#33478)Linked issues:
execution_date
parameter is malformed (#33478)len()
in utils (#33567): @eumiroLinked issues:
Linked issues:
Linked issues:
Linked issues:
Linked issues:
get_url_for_login
in security manager (#33660): @vincbeck @cesar-vermeulenLinked issues:
Linked issues:
format
in Airflow core (#33753): @hussein-awalaLinked issues:
Linked issues:
Linked issues:
Linked issues:
Thanks to all who contributed to the release (probably not a complete list!):
@agomez-etsy @Lee-W @jedcunningham @potiuk @cesar-vermeulen @pankajkoti @abhishekbhakat @dstandish @vandonr-amz @SamWheating @joeknize-bc @ephraimbuddy @ohaibbq @alexbegg @Michalosu @BohdanSemonov @pierrejeambrun @ferruzzi @eumiro @mobuchowski @Taragolis @Talvarenga @aipatr @LipuFei @Bisk1 @uranusjr @hussein-awala @vincbeck @s0neq @klexadoc @boushphong @eladkal @jens-scheffler-bosch @Owen-CH-Leung @nathadfield @ivan-afonichkin
Committer
The text was updated successfully, but these errors were encountered: