Add limit 1 if required first value from query result #33672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Aug 24, 2023
Comment on lines
+260
to
264
| return self.get_session.scalar( | ||
| select(self.registeruser_mode) | ||
| .where(self.registeruser_model.registration_hash == registration_hash) | ||
| .limit(1) | ||
| ) |
There was a problem hiding this comment.
This exposes a problem that might not be entirely in scope of the PR. If there is a hash cache, this lookup may return a wrong user and cause a security vulnarability. We should really either add a unique constraint to registration_hash, or use one_or_none here instead; both would remove the need to add a limit.
There was a problem hiding this comment.
Should I keep this changes or better revert it back?
There was a problem hiding this comment.
Keep it. We’re not sure how to change this code yet and adding this limit would be useful before we figure things out.
uranusjr
reviewed
Aug 24, 2023
2 tasks
uranusjr
approved these changes
Aug 24, 2023
potiuk
approved these changes
Aug 24, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit e8ba579)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing Limit 1 for
sqlachemy.session.scalarwhere:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.