Suspend qubole provider #33889
Merged
Suspend qubole provider #33889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
kind:documentation
provider:qubole
labels
eladkal
approved these changes
Aug 29, 2023
Taragolis
approved these changes
Aug 29, 2023
|
Interestingly enough @Taragolis boto is held still by something else as well: https://github.com/apache/airflow/actions/runs/6012796736/job/16308910701#step:5:17858 (but all the mypy-boto3-stuff will get upgraded anyway to 1.28.36 as they all have been released today and our eager upgrade mechanism takes care about it) |
|
Right.. because for some reason we had qds-sdk as devel-only dependency as well 🤦 |
Qubole has been acquired and seems that maintainers have left the project https://github.com/qubole/qds-sdk-py#where-are-the-maintainers- the package has been unmaintained for a long time and it's likely no-one uses it until someone steps up to maintain it, we suspend it
|
Removed |
|
Way better:
|
jedcunningham
approved these changes
Aug 29, 2023
Co-authored-by: Jed Cunningham <[email protected]>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 30, 2023
The `devel_only` extra puts together all dependencies that are needed for CI image and in order to run tests in local virtualenv for various test cases of ours - but they are not needed as dependencies of particular providers. They were a little "bag of everything" and they were hiding some unused dependencies or dependencies that were either unused or they were actually provider dependencies already. For example we had qds-sdk dependency there which was really the qubole provider dependency and it held us back from removing deprecated boto library from CI image (removed in apache#33889). This PR organizes the dependency a bit better: * split it to logical groups * removes some unused dependencies * moves "amazon" mypy dependency from providers to here At later stage we will move the provider ones into "[devel]" extras of the providers as part of provider decooupling, but this will require a bit more changes in CI image building and some documentation update for developers. This is an intermediate step to organize it better.
potiuk
added a commit
that referenced
this pull request
Aug 31, 2023
The `devel_only` extra puts together all dependencies that are needed for CI image and in order to run tests in local virtualenv for various test cases of ours - but they are not needed as dependencies of particular providers. They were a little "bag of everything" and they were hiding some unused dependencies or dependencies that were either unused or they were actually provider dependencies already. For example we had qds-sdk dependency there which was really the qubole provider dependency and it held us back from removing deprecated boto library from CI image (removed in #33889). This PR organizes the dependency a bit better: * split it to logical groups * removes some unused dependencies * moves "amazon" mypy dependency from providers to here At later stage we will move the provider ones into "[devel]" extras of the providers as part of provider decooupling, but this will require a bit more changes in CI image building and some documentation update for developers. This is an intermediate step to organize it better.
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Suspend qubole provider Qubole has been acquired and seems that maintainers have left the project https://github.com/qubole/qds-sdk-py#where-are-the-maintainers- the package has been unmaintained for a long time and it's likely no-one uses it until someone steps up to maintain it, we suspend it Co-authored-by: Jed Cunningham <[email protected]> (cherry picked from commit 1f0e673)
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 1, 2023
The `devel_only` extra puts together all dependencies that are needed for CI image and in order to run tests in local virtualenv for various test cases of ours - but they are not needed as dependencies of particular providers. They were a little "bag of everything" and they were hiding some unused dependencies or dependencies that were either unused or they were actually provider dependencies already. For example we had qds-sdk dependency there which was really the qubole provider dependency and it held us back from removing deprecated boto library from CI image (removed in #33889). This PR organizes the dependency a bit better: * split it to logical groups * removes some unused dependencies * moves "amazon" mypy dependency from providers to here At later stage we will move the provider ones into "[devel]" extras of the providers as part of provider decooupling, but this will require a bit more changes in CI image building and some documentation update for developers. This is an intermediate step to organize it better. (cherry picked from commit b497234)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qubole has been acquired and seems that maintainers have left the project https://github.com/qubole/qds-sdk-py#where-are-the-maintainers- the package has been unmaintained for a long time and it's likely no-one uses it until someone steps up to maintain it, we suspend it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.