-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2.7.0 db migration job errors #33652
Conversation
Nice catch ! |
How do we prevent this from happening again? I think there's a bug somewhere because it was made to work when imported directly. See Lines 79 to 86 in 2ae1c10
|
I think it's difficult to prevent - or detect upfront. This was fairly specific to having sentry integration enabled. The only way I can think of is to run our "test migration" job in CI to run will all possible options (like sentry) enabled. All options that can potentially follow different "flow" of imports. Unfortunately the way how our configuration/imporrs are done does not make it easy to avoid/detect. |
I was thinking that the import should work given that we implemented a lazy import for AirflowException so that if it's import directly it works as seen here Lines 79 to 86 in 2ae1c10
|
* Fix circular import from kubernetes_executor * Do not validate SQL when initialising Sentry --------- Co-authored-by: Lipu Fei <[email protected]> (cherry picked from commit 4bdf908)
Related to #33651
Fixes 2 issues when running Airflow 2.7.0 python 3.11 on Kubernetes with CeleryKubernetesExecutor and Sentry.
I've tested this on my Kubernetes cluster and it works.
The only doubt I have is the
validate=False
change. I'm not sure if this is the intended use.