Use airflow.exceptions.AirflowException in core
#34510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
jedcunningham,
ephraimbuddy and
dstandish
as code owners
hussein-awala
approved these changes
Sep 20, 2023
Taragolis
changed the title
airflow.exceptions.AirflowException in core
Lee-W
approved these changes
Sep 21, 2023
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
from airflow.exceptions import AirflowExceptioninstead offrom airflow import AirflowExceptionin coreIt was a reason for Circular imports in the past
In additional we have quite a few Exceptions, and only
AirflowExceptioncould be accessed fromairflow.__init__As follow up I have a plan to ban usage
from airflow import AirflowExceptionby add TID251 rule for it^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.