Differentiate 0 and unset as a default param values #33965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #33923
Pretty self explanatory, since python's zero is falsey, using
{% if form.details.value %}
led to the default value being omitted if it was a zero. This minor change makes a zero default value explicitly zero, and if a user wants to default to null they can use something like:So given the following DAG:
This was the default form before:
And this is it after:
List-type params are a whole different problem, and there's a lot of discussion in the original issue, so lets leave that for another PR? In the current implementation there's no way to explicitly pass an empty list through the form interface so I think that some changes will be definitely be required.