Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum requirement for sqlalchemy to 1.4.24 #33892

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 29, 2023

Some of the recent sqlalchemy 2 changes used features tha were added in 1.4.24 sqlalchemy (session.scalar).

We need to bump the minimum version to avoid accidental problems with people upgrading and not bumping sqlalchemy nor using constraints

Fixes: #33887


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Some of the recent sqlalchemy 2 changes used features tha were
added in 1.4.24 sqlalchemy (session.scalar).

We need to bump the minimum version to avoid accidental problems
with people upgrading and not bumping sqlalchemy nor using
constraints

Fixes: apache#33887
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 29, 2023
@jedcunningham jedcunningham merged commit bfab7da into apache:main Aug 29, 2023
64 checks passed
ephraimbuddy pushed a commit that referenced this pull request Sep 1, 2023
Some of the recent sqlalchemy 2 changes used features tha were
added in 1.4.24 sqlalchemy (session.scalar).

We need to bump the minimum version to avoid accidental problems
with people upgrading and not bumping sqlalchemy nor using
constraints

Fixes: #33887
(cherry picked from commit bfab7da)
@potiuk potiuk deleted the bump-minimum-requirements-for-sqlalchemy branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow db migrate AttributeError: 'Session' object has no attribute 'scalars'
5 participants