This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry-picks: Update more chart types and css output optimization. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2e04180)
(cherry picked from commit e12f4fb)
* update indent * extract formData and data. * take filter * remove dependencies * remove removeFilter * add comment * remove columnFormats and verboseMap from props. clarify a few more props * fix linting issue * minor syntax * syntax fix * Move check to adaptor * update unit test * remove code related to .widget * rename variables for clarity * move Option fix to browser.js (cherry picked from commit 8a4b1b7)
* Fix legend position * Add categories and play slider to arc viz * New functionality to arc viz (cherry picked from commit 6959b70)
* Extract slice and formData * organize imports (cherry picked from commit dafe0b9)
* remove unused function * remove comment (cherry picked from commit a9952bb)
* extract TTestTable into another file. * Move into directory. * update proptypes (cherry picked from commit 68e7794)
kristw
changed the title
(cherry picked from commit e35bfba)
Codecov Report
@@ Coverage Diff @@
## airbnb-master #106 +/- ##
=================================================
+ Coverage 62.96% 63.45% +0.48%
=================================================
Files 353 356 +3
Lines 22133 22156 +23
Branches 2477 2496 +19
=================================================
+ Hits 13936 14059 +123
+ Misses 8185 8085 -100
Partials 12 12
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit(s):
I have verified on devbox that the affected charts are working.
@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster