Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading vx responsive to fix ResizeObserver issue #5647

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

michellethomas
Copy link
Contributor

Upgrading vx/responsive to fix a ResizeObserver issue when setting up cypress tests. https://github.com/hshoff/vx/releases/tag/v0.0.172

Tested by:
Loading, editing, and resizing a dashboard

@kristw @williaster

@kristw
Copy link
Contributor

kristw commented Aug 16, 2018

Perhaps change "0.0.172" to "^0.0.172" so it will pick up newer version without breaking changes as well.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass 👍

@williaster
Copy link
Contributor

0.0.172 and ^0.0.172 actually should be equivalent here, either way.

Below a 1.0.0, everything is considered a breaking change so if you specify ^0.0.172 and ^0.0.185 is released, it will still be ^0.0.172.

@codecov-io
Copy link

Codecov Report

Merging #5647 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5647   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files         360      360           
  Lines       22890    22890           
  Branches     2549     2549           
=======================================
  Hits        14539    14539           
  Misses       8336     8336           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492ad6c...5c766f6. Read the comment docs.

@williaster williaster merged commit 2e04180 into apache:master Aug 16, 2018
@michellethomas michellethomas deleted the mt_upgrade_vx_responsive branch August 16, 2018 18:21
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 11, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants