add timing to stats logger #5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
add_timing_to_statsd
branch
from
247ede0
to
8d9105c
Compare
john-bodley
reviewed
Sep 10, 2018
superset/stats_logger.py
Outdated
| @@ -29,6 +29,9 @@ def decr(self, key): | |||
| """Decrement a counter""" | |||
| raise NotImplementedError() | |||
|
|
|||
| def timing(self, key, time_in_milliseconds): | |||
There was a problem hiding this comment.
If I'm reading this correctly the value can be either ms or a timedelta object, thus I wonder if time_in_milliseconds should simply be delta or value (for consistency).
There was a problem hiding this comment.
That's true. I'll change it.
Codecov Report
@@ Coverage Diff @@
## master #5844 +/- ##
==========================================
- Coverage 63.73% 63.73% -0.01%
==========================================
Files 368 368
Lines 23221 23225 +4
Branches 2600 2600
==========================================
+ Hits 14801 14803 +2
- Misses 8405 8407 +2
Partials 15 15
Continue to review full report at Codecov.
|
timifasubaa
force-pushed
the
add_timing_to_statsd
branch
2 times, most recently
from
9107a64
to
d7b428f
Compare
timifasubaa
force-pushed
the
add_timing_to_statsd
branch
from
d7b428f
to
f185083
Compare
john-bodley
approved these changes
Sep 10, 2018
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 11, 2018
(cherry picked from commit e35bfba)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to log time into the logging interface in superset.
@john-bodley @mistercrunch