[Table view] Handle empty arrays in fd.timeseries_limit_metric #5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5715 +/- ##
==========================================
+ Coverage 63.43% 63.78% +0.35%
==========================================
Files 361 362 +1
Lines 22977 22983 +6
Branches 2558 2557 -1
==========================================
+ Hits 14575 14660 +85
+ Misses 8387 8308 -79
Partials 15 15
Continue to review full report at Codecov.
|
| @@ -185,9 +185,12 @@ function tableVis(slice, payload) { | |||
| container.find('.dataTables_wrapper'), height); | |||
| // Sorting table by main column | |||
| let sortBy; | |||
| if (fd.timeseries_limit_metric) { | |||
| const limitMetric = Array.isArray(fd.timeseries_limit_metric) | |||
There was a problem hiding this comment.
No need to check on .length?
There was a problem hiding this comment.
Technically no, if the array has no elements then limitMetric is undefined, which is false and does the expected in line 191.
| // Sort by as specified | ||
| sortBy = fd.timeseries_limit_metric.label || fd.timeseries_limit_metric; | ||
| sortBy = limitMetric.label || limitMetric; |
There was a problem hiding this comment.
Unrelated to this PR: It's driving me crazy the number of places in the code where we deal with the historical metrics! We'll need to clean that up some day. Maybe that can be an early place where we enforce a typescript schema, and do it way upstream.
|
LGTM |
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…e#5715) * Handle empty arrays * Remove test code * Adding unit test * Fix unit tests * Remove logging
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…e#5715) * Handle empty arrays * Remove test code * Adding unit test * Fix unit tests * Remove logging
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of our charts
fd.timeseries_limit_metricis being initialized to an empty array instead ofnull. This results insortBybeing set to an empty array, and then the last metric column is hidden.