Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Commit

Permalink
[SIP-5] Remove unused function #easy-review (apache#5825)
Browse files Browse the repository at this point in the history
* remove unused function

* remove comment
  • Loading branch information
kristw authored and williaster committed Sep 5, 2018
1 parent dafe0b9 commit a9952bb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions superset/assets/src/chart/Chart.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,6 @@ class Chart extends React.PureComponent {
this.props.actions.chartRenderingFailed(e, this.props.chartId);
}

verboseMetricName(metric) {
return this.props.datasource.verbose_map[metric] || metric;
}

renderTooltip() {
if (this.state.tooltip) {
return (
Expand Down
4 changes: 0 additions & 4 deletions superset/assets/src/visualizations/table.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,6 @@ function adaptor(slice, payload) {
orderDesc,
pageLength: pageLength && parseInt(pageLength, 10),
percentMetrics,
// Aug 22, 2018
// Perhaps this `tableFilter` field can be removed as there is
// no code left in repo to set tableFilter to true.
// which make `onAddFilter` will never be called as well.
tableFilter,
tableTimestampFormat,
timeseriesLimitMetric,
Expand Down

0 comments on commit a9952bb

Please sign in to comment.