Enable CSS Hot Module Replacement and optimize css output for production #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xtinec said she knows Webpack very well and can help review & advise here |
xtinec
reviewed
Sep 4, 2018
superset/assets/webpack.config.js
Outdated
| @@ -2,7 +2,9 @@ const path = require('path'); | |||
| const webpack = require('webpack'); | |||
| const CleanWebpackPlugin = require('clean-webpack-plugin'); | |||
| const MiniCssExtractPlugin = require('mini-css-extract-plugin'); | |||
| const OptimizeCSSAssetsPlugin = require("optimize-css-assets-webpack-plugin"); | |||
There was a problem hiding this comment.
[Nit] '' here to get past the linter.
|
Looks good aside from the small thing to use |
|
Thanks @mistercrunch , @xtinec |
Codecov Report
@@ Coverage Diff @@
## master #5813 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 364 364
Lines 23099 23099
Branches 2587 2587
=======================================
Hits 14744 14744
Misses 8340 8340
Partials 15 15Continue to review full report at Codecov.
|
williaster
approved these changes
Sep 5, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…ion (apache#5813) * Enable HMR for css. Use style-loader for development * optimize css output * remove mini-css-extract when dev * change double-quote to single-quote
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…ion (apache#5813) * Enable HMR for css. Use style-loader for development * optimize css output * remove mini-css-extract when dev * change double-quote to single-quote
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable HMR for CSS
Current webpack settings uses
mini-css-extract-pluginfor both development and production. This plugin extract css into many small files based on the modules that imports them.However, per the package's README, it is recommended for production only especially if we want Hot Module Replacement (HMR) for CSS. To use HMR, we need to use
style-loaderwhen in development mode. Otherwise, the page will not update after saving CSS files.https://github.com/webpack-contrib/mini-css-extract-plugin#advanced-configuration-example
To ensure that
style-loaderworks correctly, I also need to modify the html templates to importthemejs entry points. Becausestyle-loaderinjects css code via js that writes<style>tags instead of exporting css files.Optimize CSS output
Current CSS output from webpack are not minified. This PR adds
optimize-css-assets-webpack-pluginto minify CSS outputs. The minification reduce CSS size by ~100kbTesting
I have tested building in production and running dev server. Both are working fine.
@graceguo-supercat @xtinec @hughhhh @conglei @williaster