dev-v2.0.0 -> staging #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging -> Main v1.1.0 Release
* Upgrade AGP, Gradle, language dependencies - Upgrades - Gradle distribution 7.5 - Gradle 7.3.1 - Java 1.8 - Kotlin 1.6.2 - jacoco 0.8.8 - Expand .gitignore - Restructure plugin declarations - Fix functional test configuration (dex, androidx.test:core)) * Fix javadoc task * Fix app namespace warning * Address review comments - remove *Version suffix for sdk options in gradle - switch to gradle 7.3.0 - Use `required` instead of `enabled` for xml, csv, html reports - Remove aar maven upload script * Fix namespace warning and rename variable * Enable multidex only for debug builds Functional tests will fail without this flag as this module exceeds the DEX limit. It is sufficient to enable this for debug as it is the type used for functional tests. Consuming apps are responsible for making changes to their gradle to overcome the DEX limit as necessary. * Remove unneeded dependencies and variables
* Core 2.0 adoption
- .gradle changes
- Add jitpack to repositories
- Consume Core 2.0 via com.github.adobe.aepsdk-core-android:core:v2.0.0-SNAPSHOT
from jitpack
- Prevent transitive dependencies from other extensions
- Change moduleVersion, mavenCoreVersion to 2.0.0.
- Change IdentityConstants.EXTENSION_VERSION to 2.0.0
- Expose IdentityExtension.class via Idenity.EXTENSION
- Switch to MobileCore.dispatchEventWithResponseCallback(event, timeout, callbackWithError)
and ExtensionApi.dispatch(event)
- Switch to using new shared state api
- Remove multiple instance creation of SharedStateCallback.
- Streamline shared state calls via SharedStateCallback within and
outside the Identity extension
- Implement IdentityExtension.onRegistered()
- Change event listener registration to be done in onRegistered() instead of the
IdentityExtension's constructor
- Remove Listener*.java classes in favor of inline methods
- Remove the inhouse executor service and mutex as the events are now incident
via a single thread maintained by the extension container housing this extension.
- Implement IdentityExtension.readyForEvent()
- Add logic to wait for EventHub state and IdentityDirect registration check
if ECID from persisted properties is unavailable.
- Remove the logic to cache events internally. Take advantage of the Hub
shared state fetching to boot up and disambiguate between Identity direct and
EdgeIdentity.
- Switch to use public utility classes and methods from Core where applicable
- Use StringUtils.isEmpty()
- Use JSONUtil.toMap() and JSONUtil.toList()
- Use DataReader.opt*() to read and parse event data. Remove class cast
exception guards and resolve unchecked cast warnings where possible.
- General changes done on code path toched
- private and finals where applicable
- Use cascading constructors to eliminate constructor divergence risk and
ease test injection
Out of scope for this PR
- Switching to Log from MobileCore.Log
- Switching IdentityStorageService to NamedCollection
- Test changes
- PowerMock elimination
* Core 2.0 adoption
- .gradle changes
- Add jitpack to repositories
- Consume Core 2.0 via com.github.adobe.aepsdk-core-android:core:v2.0.0-SNAPSHOT
from jitpack
- Prevent transitive dependencies from other extensions
- Change moduleVersion, mavenCoreVersion to 2.0.0.
- Change IdentityConstants.EXTENSION_VERSION to 2.0.0
- Expose IdentityExtension.class via Idenity.EXTENSION
- Switch to MobileCore.dispatchEventWithResponseCallback(event, timeout, callbackWithError)
and ExtensionApi.dispatch(event)
- Switch to using new shared state api
- Remove multiple instance creation of SharedStateCallback.
- Streamline shared state calls via SharedStateCallback within and
outside the Identity extension
- Implement IdentityExtension.onRegistered()
- Change event listener registration to be done in onRegistered() instead of the
IdentityExtension's constructor
- Remove Listener*.java classes in favor of inline methods
- Remove the inhouse executor service and mutex as the events are now incident
via a single thread maintained by the extension container housing this extension.
- Implement IdentityExtension.readyForEvent()
- Add logic to wait for EventHub state and IdentityDirect registration check
if ECID from persisted properties is unavailable.
- Remove the logic to cache events internally. Take advantage of the Hub
shared state fetching to boot up and disambiguate between Identity direct and
EdgeIdentity.
- Switch to use public utility classes and methods from Core where applicable
- Use StringUtils.isEmpty()
- Use JSONUtil.toMap() and JSONUtil.toList()
- Use DataReader.opt*() to read and parse event data. Remove class cast
exception guards and resolve unchecked cast warnings where possible.
- General changes done on code path toched
- private and finals where applicable
- Use cascading constructors to eliminate constructor divergence risk and
ease test injection
Out of scope for this PR
- Switching to Log from MobileCore.Log
- Switching IdentityStorageService to NamedCollection
- Test changes
- PowerMock elimination
* Address review comments
- Switch to using handlers for each event listener
- Use TimeUtils where applicable
- Eliminate two calls to get event hub shared state
- Add comments and TODOs for verification and logging
* Switch to SNAPSHOT core artifact
* Change callback timeout to 500ms to match API contract
- Make IdentityStorageService methods non-static and inject from constuctor - Rename IdentityStorageService to IdentityStorageManager
Adopt Log service and DataStoreService changes from Core 2.0
Remove Powermock and fix unit and functional tests
* Set pending shared state before updating identity map * Create pending state when resetIdentities is called.
* Annotations, unit tests++ * Update test app * Update registerExtension test * Update docs
Codecov Report
@@ Coverage Diff @@
## staging #84 +/- ##
============================================
+ Coverage 81.30% 93.37% +12.07%
============================================
Files 20 12 -8
Lines 1032 679 -353
Branches 151 103 -48
============================================
- Hits 839 634 -205
+ Misses 137 16 -121
+ Partials 56 29 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dev -> staging for 2.0.0-SNAPSHOT covering the integration with core 2.0.0
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: