Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Constants from Core and add friendly name #79

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

prudrabhat
Copy link
Contributor

@prudrabhat prudrabhat commented Dec 16, 2022

Description

EdgeIdentityExtension currently uses local constants for EventType and EventSource. These constants are now provided in Core. Use the constants from core.

Related Issue

MOB-17816

Motivation and Context

EdgeIdentityExtension currently uses local constants for EventType and EventSource. These constants are now provided in Core. Use the constants from core.

How Has This Been Tested?

  • Unit tests
  • build verification

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #79 (ac64470) into dev-v2.0.0 (afebb93) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           dev-v2.0.0      #79      +/-   ##
==============================================
- Coverage       93.33%   93.32%   -0.01%     
==============================================
  Files              12       12              
  Lines             675      674       -1     
  Branches          103      103              
==============================================
- Hits              630      629       -1     
  Misses             16       16              
  Partials           29       29              
Flag Coverage Δ
functional-tests 67.36% <100.00%> (-0.05%) ⬇️
unit-tests 93.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adobe/marketing/mobile/edge/identity/Identity.java 92.04% <ø> (ø)
.../marketing/mobile/edge/identity/IdentityState.java 95.83% <ø> (ø)
...keting/mobile/edge/identity/IdentityExtension.java 99.15% <100.00%> (-0.01%) ⬇️

@emdobrin emdobrin merged commit fd3214d into adobe:dev-v2.0.0 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants