Upgrade AGP, Gradle, language dependencies #75
Conversation
- Upgrades - Gradle distribution 7.5 - Gradle 7.3.1 - Java 1.8 - Kotlin 1.6.2 - jacoco 0.8.8 - Expand .gitignore - Restructure plugin declarations - Fix functional test configuration (dex, androidx.test:core))
prudrabhat
force-pushed
the
dev-v2.0.0_setup
branch
2 times, most recently
from
f4553b5 to
d4344a8
Compare
prudrabhat
force-pushed
the
dev-v2.0.0_setup
branch
from
d4344a8 to
0c7fb74
Compare
prudrabhat
requested review from
kevinlind,
emdobrin,
cacheung and
timkimadobe
- remove *Version suffix for sdk options in gradle - switch to gradle 7.3.0 - Use `required` instead of `enabled` for xml, csv, html reports - Remove aar maven upload script
|
We have another AndroidManifest.xml at |
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.0 #75 +/- ##
==============================================
+ Coverage 81.30% 81.69% +0.40%
==============================================
Files 20 20
Lines 1032 1027 -5
Branches 151 151
==============================================
Hits 839 839
+ Misses 137 132 -5
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Functional tests will fail without this flag as this module exceeds the DEX limit. It is sufficient to enable this for debug as it is the type used for functional tests. Consuming apps are responsible for making changes to their gradle to overcome the DEX limit as necessary.
There was a problem hiding this comment.
In code/edgeidentity/build.gradle please update publishing/publications/release with the following:
pom {
url = 'https://developer.adobe.com/client-sdks'
}
scm {
connection = 'scm:git:github.com//adobe/aepsdk-edgeidentity-android.git'
developerConnection = 'scm:git:ssh://github.com//adobe/aepsdk-edgeidentity-android.git'
url = 'https://github.com/adobe/aepsdk-edgeidentity-android'
}
code/build.gradle
Outdated
| // build tools | ||
| buildToolsVersion = "29.0.3" |
There was a problem hiding this comment.
Setting the build tools version shouldn't be required anymore, can you remove this?
| // dependencies | ||
| junitVersion = "1.1.2" | ||
| // kotlin config | ||
| kotlinVersion = "1.6.21" |
There was a problem hiding this comment.
I don't see this kotlinVersion being used, can you remove it?
There was a problem hiding this comment.
It is being used in code/app/build.gradle Line#48.
| prettierVersion = "2.7.1" | ||
| prettierPluginJavaVersion = "1.6.2" |
There was a problem hiding this comment.
Can you use these variables in the Spotless configuration in code/edgeidentity/build.gradle line 20?
code/edgeidentity/build.gradle
Outdated
| // It is sufficient to enable this for debug as it is the type used for functional tests. | ||
| // Consuming apps are responsible for making changes to their gradle to overcome | ||
| // the DEX limit as necessary. | ||
| multiDexEnabled true |
There was a problem hiding this comment.
I think you can remove this if you remove the dependencies implementation 'androidx.appcompat:appcompat:1.2.0' and androidTestImplementation "androidx.test:core:1.4.0". In my testing neither dependency was needed.
However, when I also updated com.fasterxml.jackson.core:jackson-databind to 2.12.7 and androidx.test.espresso:espresso-core to 3.5.0, then I went over the dex limit again by about 20 methods. At this point I'd suggest removing multidex and the to unneeded dependencies.
There was a problem hiding this comment.
You are correct! Both of these dependencies are not needed for this project as well and removing it reduced the method count below dex limit.
Description
Related Issue
MOB-17088
Motivation and Context
Upgrade tools and dependancies in preparation for Android Core 2.0 adoption.
How Has This Been Tested?
ci-build,ci-javadocci-unit-testci-funtional-testpass locally.Screenshots (if appropriate):
N/A
Types of changes
Checklist: