Adding annotations on public APIs #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudrabhat
reviewed
Jan 12, 2023
...ity/src/androidTest/java/com/adobe/marketing/mobile/edge/identity/IdentityPublicAPITest.java
Show resolved
Hide resolved
prudrabhat
previously approved these changes
Jan 12, 2023
prudrabhat
dismissed
their stale review
Pending question. Requested clarification on a test.
Codecov Report
@@ Coverage Diff @@
## dev-v2.0.0 #83 +/- ##
==============================================
- Coverage 93.32% 93.30% -0.02%
==============================================
Files 12 12
Lines 674 672 -2
Branches 103 103
==============================================
- Hits 629 627 -2
Misses 16 16
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
addb
reviewed
Jan 12, 2023
| */ | ||
| @Deprecated | ||
| @SuppressWarnings("deprecation") |
There was a problem hiding this comment.
Why are we suppressing warnings here?
There was a problem hiding this comment.
it shows a warning in the IDE when using the registerExtension API so it suppresses that, but you would still see the deprecation message on the API itself
10 tasks
prudrabhat
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: