Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, remove jetifier #80

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

emdobrin
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #80 (30fb747) into dev-v2.0.0 (fd3214d) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           dev-v2.0.0      #80   +/-   ##
===========================================
  Coverage       93.32%   93.32%           
===========================================
  Files              12       12           
  Lines             674      674           
  Branches          103      103           
===========================================
  Hits              629      629           
  Misses             16       16           
  Partials           29       29           
Flag Coverage Δ
functional-tests 67.36% <ø> (-0.89%) ⬇️
unit-tests 93.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@timkimadobe timkimadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but wondering if we should just update rootProject.mavenCoreVersion instead of adding a new implementation line for Core.

code/app/build.gradle Show resolved Hide resolved
@emdobrin emdobrin merged commit be93222 into adobe:dev-v2.0.0 Dec 22, 2022
@emdobrin emdobrin deleted the jetifier branch January 7, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants