Staging -> Main v1.1.0 Release #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README and add boilerplate leagal docs * Add top-level .gitignore * Add base IdentityEdge extension * Add Makefile * Add CircleCI config * Rename files from IdentityEdge to Identity * Update README installation instructions * Use extension name constant.
…ded Listeners (#2) * [AMSDK-11119] - Rename to IdentityEdge, Move to identity package + listeners
* Add circleci job to run functional tests in an emulator * Fix yaml formatting in circleci config * rename circleci job to build-and-unit-test * Call Make targets when running functional tests
* Add ECID and tests * Add IdentityMap from Edge extension * Create IdentityEdgeProperties and tests * Add utils copied from Edge * Create storage service * Add required constants * Create IdentityEdgeState and tests * Rename extension version test class * Add doc comment * Doc comment for storage service * Remove configuration handling * Fix IdentityEdgeState log tag * update event names * Make ECID parameter final * Update class comment for IdentityEdgeProperties * Make getECID protected * getIdentityProperties -> getIdentityEdgeProperties * Remove config listener and remove unused imports * Make IdentityEdgeState methods protected * Add test for ECID(final String ecidString) * Remove config listener * Fix complier issue * Remove test to be added in a following PR * persist data in xdm format * Use extension name as datastore name * Update listener doc comment * Update event type in doc comment * Save after generating ECID and add assertion in test * Add null check in IdentityMap.fromData * Add null check in IdentityEdgeProperties.readECIDFromIdentityMap * Improve doc comments, logs, and handle empty/null ECID string * Add tests for storage service
* Add ECID and tests * Add IdentityMap from Edge extension * Create IdentityEdgeProperties and tests * Add utils copied from Edge * Create storage service * Add required constants * Create IdentityEdgeState and tests * Rename extension version test class * Add doc comment * Doc comment for storage service * Remove configuration handling * Fix IdentityEdgeState log tag * update event names * Make ECID parameter final * Update class comment for IdentityEdgeProperties * Make getECID protected * getIdentityProperties -> getIdentityEdgeProperties * Remove config listener and remove unused imports * Make IdentityEdgeState methods protected * Add test for ECID(final String ecidString) * Remove config listener * Start on public API * Fix complier issue * Remove test to be added in a following PR * persist data in xdm format * Use extension name as datastore name * Update listener doc comment * Update event type in doc comment * Save after generating ECID and add assertion in test * Add null check in IdentityMap.fromData * Add null check in IdentityEdgeProperties.readECIDFromIdentityMap * Add tests for IdentityEdgeExtension ECID getter * Add copyright to IdentityEdgeExtensionTests * Add tests for public get ECID API * Improve doc comments, logs, and handle empty/null ECID string * Add tests for storage service * remove unused import * Fix comments and logs * Fix listener event source * fix listener source in tests * Revert un-needed listener change * Handle case where there are empty IDs * Add null check for identity map * Invoke with empty identity map when no ECID found and replace ecidString with toString * Move ECID read to IdentityMap * use raw data for API tests * Ensure when IdentityEdgeProps is empty we dispatch an empty map * Add test with invalid event data * add log when failing to get extension api
* Add resetIdentties API * Add required constants * Add reset listener * Handle reset event * Add test for handleRequestEvent * Add ticket number in TODO * Update test_ListenersRegistration for new listener * Improve log and null check * Don't allow empty when setting shared state and assert ECID length on regeneration * improve assertion
* [AMSDK-11081] - Rename listener tests * [AMSDK-11081] - Listeners for remove and update Identity requests + tests * [AMSDK-11081] - UpdateIdentity Public API
* Add IdentityItem * Add tests for identity item * add convince overloaded constructor * Throw IllegalArgumentException if id null and add test * Add override for hashCode * Update access levels and update API signatures in IdentityItem * Clean up merge * Fix java doc * fix java doc * invert expression * Deep copy on getIdentityItemsForNamespace * Invert params * Add throws to javadoc * move throws doc to bottom of comment * use @link for javadoc * Rename IdentityEdge event type to EdgeIdentity * Add final * Add test for equals * Fix assertion * Add import
* Add getIdentities API * Add java doc and fix event name in log * Rename test * Use JSON string for test and update auth state json key * Fix auth key in tests * fix sentence in java doc
…unctional test (#9) * [Dev] - Add the functional test helpers + first valid functional test * [Dev] - First functional test * [Dev] - Assertion fail on misread of persistence in TestPersistence helper method
* Add method to load ECID from direct Identity datastore. * Load ECID from direct identity during IdentityState bootup * Add secondary ecid to IdentityProperties * Add API to update legacy ECID in IdentityState * Add listener for Hub Shared State changes from direct Identity to update legacy ECID value. * Correct copywrite on new files * Make ListenerHubSharedStateTests class public * handle class cast exceptions and mark local variables final * Make ECID class final and add unit tests for equals and hashCode * Correct documentation in ListenerHubSharedState * final local variables
* Remove rest identities API * Update doc comment in listener * Add reset complete event source * Update event source for reset response event
…et (#15) * Add unit test to verify secondary ECID is not set if primary is not set * Make class variables final
) * [AMSDK-11081] - Update/Remove Identity API implementation * [AMSDK-11081] - Unit test for IdentityMap and RemoveIdentity Public API * [AMSDK-11081] - More Unit test for update/Remove * [AMSDK-11081] - Few more edits to unittests * [AMSDK-11081] - better naming and typo fixes * [AMSDK-11081] - rearrange parameters, setECID handling, case-insensitive search and more * [AMSDK-11081] - Caseinsensitive removal of reserved namespace items + cleanup * [AMSDK-11081] - cleanup and renaming
* [AMSDK-11081] - Rename listener tests * [AMSDK-11081] - Listeners for remove and update Identity requests + tests * [AMSDK-11081] - UpdateIdentity Public API * [AMSDK-11081] - Fix spacings in IdentityMap class * [Dev] - Add the functional test helpers + first valid functional test * [Dev] - First functional test * [Dev] - Assertion fail on misread of persistence in TestPersistence helper method * [AMSDK-11081] - Update/Remove Identity API implementation * [AMSDK-11081] - Unit test for IdentityMap and RemoveIdentity Public API * [AMSDK-11081] - More Unit test for update/Remove * [AMSDK-11081] - Few more edits to unittests * [AMSDK-11081] - better naming and typo fixes * [AMSDK-11081] - rearrange parameters, setECID handling, case-insensitive search and more * [AMSDK-11081] - Caseinsensitive removal of reserved namespace items + cleanup * [AMSDK-11081] - cleanup and renaming * [Dev] - Rename enum to AuthenticatedState and fix its toString * [Dev] - Enum AuthenticatedState * [Dev] - removed local ecid and secondaryECID local instances variables * [AMSDK-11081] - final on IdentityMap, enum string comparison change
* [AMSDK-11140] Renaming to edgeidentity rename package to edge.identity rename module to edgeidentity rename to edgeidentity, extension name, class, listeners, constants Rename internal classes to Identity* rename to testApp Renaming in Makefile, readme * Updates after rebase * Review impl - circleci update after renaming
* [AMSDK-11312] - Handle Boot event and share initial shared state * [AMSDK-11312] - Bug fix on merge Identities * [AMSDK-11312] - Bootsup during extension registration * [AMSDK-11312] - update tests for boot up change * Cleanup asXDMIdentityMap + unit test renaming
* Use correct direct Identity data store name * Override toString in IdentityMap and IdentityItem * Add Kotlin test app for IdentityEdge * Add fragment for starting an Assurance session * Remove unused test files from sample app. * Add implementations for send event and reset identities buttons. * Add Application class to initialize SDK and extensions * Add network security config to AndroidManifest * Comment out call to resetIdentities as API in Core is not yet released * Remove Java app * Rename 'appkt' to 'app' and move files to 'code/app' * Remove launch environment ID * Rename test app package from 'appkt' to 'app' * fix IdentityMap.toString to handle case where map is empty. * Use correct AuthenticatedState.loggedOut string * Save custom identifier UI entries and update UI with saved values when page is viewed. * Remove copyright from non-source files (Manifest, layouts, drawables, etc). * Make StringBuilder final in IdentityMap.toString()
* [AMSDK-11329] - Functional test for EdgeIdentity
* [Dev] - Log fixes + cleanup + fix sonarlint issues
* Update build script for publishing to sonatype and removing publish to bintray and artifactory. * Update Makefile with publish targets for sonatype * Remove publish job from CircleCI configuration. * Create common build-release Makefile target used by publish targets * Only include Core dependency when generating POM file for publish * Remove extra bracket from build.gradle
* Create maven-snapshot.yml * Use Java 1.7
* Create maven-release.yml * Use Java 1.7 * Fix step name, publish to staging repo
Set version to 1.0.0
* Update core dependency to 1.8.0 * Add todo to remove mvn url for core
Testing implementation for supporting advertising identifier
* Update test app with fetch GAID capabilities Add ability to set custom ad ID and update ad ID with current GAID * Update gradle and manifest to allow for multi-dex * Update code format * Remove multi-dex SDK * Include Edge Consent extension in build.gradle and register extension in test app startup * Add button to get current consents values, using Consent.getConsents API * Add ad ID special value case buttons to handle setting the null and all-zeros cases * Remove documentation details from test app implementation; see documentation branch for detailed documentation * Add adherence to isLimitAdTrackingEnabled for obtaining ad ID * Improve logging for ad ID exception cases Revert wildcard import for android.widget * Update ad ID opt-out case to send empty string ad ID to MobileCore; clears out any existing ad ID * Enable multi-dex and add multidex SDK * Revert gradle version to dev branch version * Reverting gradle wrapper properties to dev branch values * Remove debug log * Update log calls in SharedViewModel to use LOG_TAG * Update log calls in CustomIdentityFragment to use LOG_TAG * Refactor coroutine logic to convert ad ID getter to pure getter, and fetch value using appropriate background context Update AndroidManifest to use secrets access, and gitignore Remove unused libraries from import Update logging constants to be file level constants for efficiency * Create secrets.xml Manually adding secrets file, with placeholder value
* Update Readme for demo app setup steps Update Readme for demo app setup steps * Update readme with review comments Update readme with review comments * remove the extra spaces remove the extra spaces
* [MOB-15817] Implemented getUrlVariables public API * [MOB-15817] Added unit tests for getUrlVariable implementation logic * [MOB-15817] Updated sample app with getUrlVariable public API * [MOB-1917] Clear config * [MOB-15817] Format fixes * [MOB-15817] Fix javadoc * [MOB-15817] minor bug fix and test fixes * [MOB-15817] Add more tests * [MOB-15817] Add tests, make minor fixes and review fixes * [MOB-15817] Fix test and added a test to improve coverage * [MOB-15817] Minor refactoring based on reviews * [MOB-15817] More tests, minor refactoring and review fixes * [MOB-15817] Review fixes * [MOB-15817] Fix method java doc description * [MOB-15817] Used java.net.URLEncoder instead of custom implementation. Added few tests. Also added review fixes. * [MOB-15817] Added more tests for URL encoder * [MOB-15817] Cleanup urlEncode helper and tests
…and api reference pages (#61) * [MOB-15818] Added documentation directory with getting started guide and api reference pages * [MOB-15818] Review fixes
* Update test app with fetch GAID capabilities Add ability to set custom ad ID and update ad ID with current GAID * Update gradle and manifest to allow for multi-dex * Update code format * Remove multi-dex SDK * Include Edge Consent extension in build.gradle and register extension in test app startup * Add button to get current consents values, using Consent.getConsents API * Add ad ID special value case buttons to handle setting the null and all-zeros cases * New Documentation directory with all relevant documentation for Edge Identity extension * Remove documentation details from test app implementation; see documentation branch for detailed documentation * Add adherence to isLimitAdTrackingEnabled for obtaining ad ID * Improve logging for ad ID exception cases Revert wildcard import for android.widget * Update ad ID opt-out case to send empty string ad ID to MobileCore; clears out any existing ad ID * Documentation update * Documentation update * Enable multi-dex and add multidex SDK * Revert gradle version to dev branch version * Reverting gradle wrapper properties to dev branch values * Include screenshots of Android ad ID settings (old and new) with standardized width controls Add assets folder with images of Android ad ID settings (old and new) * Add Android to section header Add period to bullet point * Remove debug log * Update log calls in SharedViewModel to use LOG_TAG * Update log calls in CustomIdentityFragment to use LOG_TAG * Update README with Development tip for M1 machine build issues * Update M1 development tips to include error snippet and note about keeping build config changes local * Update documentation text and image sizing * Refactor coroutine logic to convert ad ID getter to pure getter, and fetch value using appropriate background context Update AndroidManifest to use secrets access, and gitignore Remove unused libraries from import Update logging constants to be file level constants for efficiency * Create secrets.xml Manually adding secrets file, with placeholder value * Resize image and add code example * Update ad ID settings wording to refer to Android environments Simplify ad ID manifest permissions section * Update filename and headers * Remove old file * Overhaul of documentation format; Move sections to more relevant locations Update opt-in/out wording to tracking authorization Reference Google documentation for source of truth * Update wording * Consolidate Google Mobile Ads Lite SDK section description and impl example into one Update description to include link to full SDK as well * Update readme to include link to new Documentation directory * Update wording for clarity
Support for advertising identifier and adId consent collection
* Update env file ID var name and help text for consistency with other repos * Create api reference for setAdvertisingIdentifier * Add API arg description * Add more context for key terms * Update wording for all-zeros case Update min version requirement * Remove UUID reference link; common ID standard Update syntax arg description
Documentation update: setAdvertisingIdentifier API reference (#65)
Fetch dev branch to get the AdId implementation and documentation
Feature: Added new getUrlVariables API
Bump version to 1.1.0
* Update env file ID var name and help text for consistency with other repos * Create api reference for setAdvertisingIdentifier * Add API arg description * Add more context for key terms * Update wording for all-zeros case Update min version requirement * Remove UUID reference link; common ID standard Update syntax arg description * Add button for setting ad ID to empty string Add code block comenting system to ad ID features Add hint log for commented out button functionality Remove env file ID * Create Documentation/README for instructions on how to enable ad ID features Add images from sample app for documentation * Apply formatting * Update main readme for ad ID enable steps * Readme update for edge consent requirement * Update wording * Update wording in run instructions Co-authored-by: Arjun Bhadra <[email protected]>
Dev->Staging v1.1.0 Release
emdobrin
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: