Update Android test app to use ad ID feature comment blocks #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update min version requirement
Update syntax arg description
Add code block comenting system to ad ID features Add hint log for commented out button functionality Remove env file ID
…eatures Add images from sample app for documentation
addb
reviewed
Jun 7, 2022
code/app/src/main/java/com/adobe/marketing/edge/identity/app/model/SharedViewModel.kt
Outdated
Show resolved
Hide resolved
addb
approved these changes
Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## dev #71 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 20 20
Lines 1032 1032
Branches 151 151
=======================================
Hits 839 839
Misses 137 137
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. |
cacheung
approved these changes
Jun 7, 2022
addb
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the test app so that GAID related ad ID capabilities are disabled by default so as not to be a breaking change for existing test app users; by following the instructions for enabling the features, the app should be properly configured for testing these features and not cause app launching issues.
Related Issue
Related to the updates made for the Android sample app described in the task: MOB-16412
Motivation and Context
Ad ID feature testing capability is available but does not break existing builds, and should be easy to enable/disable.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: