Documentation update: setAdvertisingIdentifier API reference (#65) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update env file ID var name and help text for consistency with other repos * Create api reference for setAdvertisingIdentifier * Add API arg description * Add more context for key terms * Update wording for all-zeros case Update min version requirement * Remove UUID reference link; common ID standard Update syntax arg description
Codecov Report
@@ Coverage Diff @@
## dev #66 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 19 19
Lines 922 922
Branches 140 140
=======================================
Hits 747 747
Misses 123 123
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. |
timkimadobe
approved these changes
Jun 7, 2022
addb
reviewed
Jun 7, 2022
| } catch (IOException e) { | ||
| // Unrecoverable error connecting to Google Play services (e.g., | ||
| // the old version of the service doesn't support getting AdvertisingId). | ||
| MobileCore.log(LoggingMode.DEBUG, "ExampleActivity", "IOException while retrieving the advertising identifier " + e.getLocalizedMessage()); |
There was a problem hiding this comment.
Let's change the logger to the Android logger as we do it for the below kotlin sample.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings doc updates from feature branch.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: