Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme for demo app setup steps #60

Merged
merged 3 commits into from
May 6, 2022

Conversation

cacheung
Copy link
Contributor

@cacheung cacheung commented May 6, 2022

Update Readme for demo app setup steps

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cacheung cacheung requested a review from emdobrin May 6, 2022 19:38
Update Readme for demo app setup steps
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #60 (01c7170) into feature/adIdConsent (119b32c) will not change coverage.
The diff coverage is n/a.

❗ Current head 01c7170 differs from pull request most recent head ad997b2. Consider uploading reports for the commit ad997b2 to get more accurate results

@@                 Coverage Diff                  @@
##           feature/adIdConsent      #60   +/-   ##
====================================================
  Coverage                81.02%   81.02%           
====================================================
  Files                       19       19           
  Lines                      922      922           
  Branches                   140      140           
====================================================
  Hits                       747      747           
  Misses                     123      123           
  Partials                    52       52           
Flag Coverage Δ
functional-tests 61.06% <ø> (-0.11%) ⬇️
unit-tests 79.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Update readme with review comments
Copy link
Contributor

@emdobrin emdobrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with a small fix for links

README.md Outdated Show resolved Hide resolved
@emdobrin emdobrin merged commit 843f5d8 into adobe:feature/adIdConsent May 6, 2022
remove the extra spaces
@cacheung cacheung deleted the readmeupdate branch May 6, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants