[RNMobile] Upgrade to RN 0.64

[dratwas]

Description

Upgrade React Native to version 0.64.0 (See RN Upgrade Helper)

Related PRs:

• Gutenberg-Mobile: Upgrade to RN 0.64.0 wordpress-mobile/gutenberg-mobile#3430
• WPiOS: Upgrade React Native to 0.64 wordpress-mobile/WordPress-iOS#16562
• WPAndroid: Upgrade React Native to 0.64 wordpress-mobile/WordPress-Android#14702
• react-native-svg PR: Upgrade to rn 0.64 wordpress-mobile/react-native-svg#12
• react-native-keyboard-aware-scroll-view PR: Fix errors received after upgrading to RN 0.64 wordpress-mobile/react-native-keyboard-aware-scroll-view#12
• react-native-gesture-handler PR: Upgrade to 64 wordpress-mobile/react-native-gesture-handler#1
• react-native-video: Upgrade to rn 0.64 wordpress-mobile/react-native-video#10
• react-native-linear-gradient: Upgrade to RN 0.64 wordpress-mobile/react-native-linear-gradient#1
• react-native-hsv-color-picker: Upgrade to RN 0.64 wordpress-mobile/react-native-hsv-color-picker#1
• react-native-safe-area-context upgrade PR: Upgrade from upstream and build against RN 0.64.0 on JitPack wordpress-mobile/react-native-safe-area-context#2
• react-native-slider: Build against RN 0.64.0 on JitPack wordpress-mobile/react-native-slider#6
• react-native-get-random-values: Build against RN 0.64.0 on JitPack wordpress-mobile/react-native-get-random-values#1
• react-native-masked-view: Build against RN 0.64.0 on JitPack wordpress-mobile/react-native-masked-view#2
• react-native-screens: Build against RN 0.64.0 on JitPack wordpress-mobile/react-native-screens#2
• react-native-reanimated: Build against RN 0.64.0 on JitPack wordpress-mobile/react-native-reanimated#2
• react-native-prompt-android: Build against RN 0.64.0 on JitPack wordpress-mobile/react-native-prompt-android#3

How has this been tested?

To test: Gutenberg Editor should work as expected.
Try to run all the manual tests.

Remaining Tasks:

• rnmobile/try/upgrade-0-64 branch is updated to 0.64.0-rc3 and needs to be updated to 0.64.0 stable.
• rnmobile/try/upgrade-0-64 needs to be updated with latest gutenberg trunk which contains some larger updates for handling WPAndroid composite builds
• iOS Demo App needs to be fixed on rnmobile/try/upgrade-0-64
• Need to create relevant PRs in other Repos following model of Upgrade React Native to 0.63 wordpress-mobile/gutenberg-mobile#2580
• Re-target to Gutenberg Web React 17 update branch, or bring those changes in here
• Check CI across all repos and address any issues

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[hypest]

Had a look at the native mobile changes and look good to me! I've only left some non-blocking comments.

Also, I didn't particularly review the iOS side changes but I trust our (successful) testing so far for that. At this point, and since the upgrade effort is already monumental, takes long time and is hard to keep up-to-date, I'm fine with optimistically merging and we can fix any issues afterwards.

That said, since a few folks are doing a pass on the web-side of things (I see @gziolo's for example), let's wait for those review passes to conclude as well before merging.

[gziolo]

From my perspective, the only concern for merging this PR is npm ci replaced in npm install in GitHub actions. It's something that we could change to move forward but we need to have a clear idea why it fails and how we can resolve it.

[youknowriad]

From my perspective, the only concern for merging this PR is npm ci replaced in npm install in GitHub actions.

Can we just revert that and see, I think the main problem for these failures is independent from the upgrade.

[youknowriad]

Note that the two failures we're seeing now (performance and post title) are unrelated for this PR and exists on trunk and we're working on them in #32686

[gziolo]

Great work, assuming that npm ci works the same way as other PRs at the moment, this patch looks good to go.

Amazing teamwork everyone involved to get RN 0.64 and React 17 upgrades working 🎉 👏🏻

[ceyhun]

Note that the two failures we're seeing now (performance and post title) are unrelated for this PR and exists on trunk and we're working on them in #32686

Great to hear that 😅 I've pushed 2 commits (85c4331, e8cd4af) replacing npm install with npm ci to how they were before. Didn't see any cb() never called! errors, but I fear that might be related to ~/.npm cache still being in place and maybe the error will return when a new change to package-lock.json that makes the cache invalid. In any case I think we can go back to npm install or try to find another solution if that ever happens.

I'll get one final merge from trunk to fix remaining checks as #32686 seems to have been merged to trunk.