Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg hash to point to extra RN 0.64 updates #16665

Closed
wants to merge 1 commit into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 10, 2021

Fixes #

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3597

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 50172. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2021

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@hypest hypest added the Gutenberg Editing and display of Gutenberg blocks. label Jun 10, 2021
Base automatically changed from gutenberg/upgrade-RN-0-64 to develop June 16, 2021 19:48
@hypest
Copy link
Contributor Author

hypest commented Jun 17, 2021

Fix has been included in the main RN 0.64 upgrade PRs already and those got merged already so, closing this 🎉.

@hypest hypest closed this Jun 17, 2021
@dcalhoun dcalhoun deleted the gutenberg/upgrade-RN-0-64-hypest branch June 22, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant