Upgrade React Native to 0.64

[ceyhun]

Upgrading react-native to version 0.64.0

To test: Follow instructions on gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3430

Regression Notes

1. Potential unintended areas of impact

• The whole Gutenberg editor could be affected

2. What I did to test those areas of impact (or what existing automated tests I relied on)

• Went through the writing flow tests

3. What automated tests I added (or what prevented me from doing so)

• Gutenberg Mobile has it's own automated tests and doesn't rely on WPiOS's automated tests for now (except the limited EditorGutenbergTests)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can trigger an installable build for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

[mokagio]

Bumping this to 17.7 as part of the open PRs walkthrough before starting the 17.6 code freeze because there are conflicting files and it hasn't been reviewed yet.

Ping me here if this can't wait two weeks and needs to go into 17.6 once approved. 👍

[guarani]

Hi @ceyhun 👋

@buildkite buildkite/wordpress-ios — Build #629 failed (32 minutes, 53 seconds)

Looking at https://buildkite.com/wordpress-mobile/wordpress-ios/builds/629, the UI tests for iPhone and iPad failed with errors like:

[14:11:57]: ▸ EditorGutenbergTests
[14:12:33]: ▸ <span class="term-fg35">    ✗ testBasicPostPublish, XCTAssertTrue failed - Page WordPressUITests.PasswordScreen is not loaded.</span>

Is this a known issue?

---

A couple of other things I wasn't sure about:

1. I went to the Gutenberg Mobile PR to check what to test and it says to try to run all the manual tests. I'm unsure if this means I should do the writing flow tests (as you did for Android here), or different manual tests (block tests for example)?
2. Was the Regression Notes section left empty intentionally?

[guarani]

I smoke tested the app using the App Center build and didn't see any issues. I held off manual testing because I wasn't sure which areas need testing the most.

[ceyhun]

Thanks for the review @guarani!

Looking at buildkite.com/wordpress-mobile/wordpress-ios/builds/629, the UI tests for iPhone and iPad failed with errors like:
Is this a known issue?

I think it's safe to ignore Buildkite failures for now (internal references p1621980493008500-slack-CEJT26EG1 , p1623844140451700-slack-CC7L49W13).

1. I went to the Gutenberg Mobile PR to check what to test and it says to try to run all the manual tests. I'm unsure if this means I should do the writing flow tests (as you did for Android here), or different manual tests (block tests for example)?

After that one, there was another pass of writing flow test both on WPiOS and WPAndroid mentioned here. That was done on a branch fixing WPAndroid errors targeting RN 0.64 upgrade branch. The changes for the fix were cherry-picked to the RN 0.64 upgrade branch.

I smoke tested the app using the App Center build and didn't see any issues. I held off manual testing because I wasn't sure which areas need testing the most.

Thanks again! I think that should be enough for now and other than that I guess it would take a lot of time to go through every manual test and we may have to rely on automated ones and the future release tests we'll have.

2. Was the Regression Notes section left empty intentionally?

I thought the regression notes didn't really fit well with a big change like a React Native upgrade it's really hard to tell. I guess the whole Gutenberg editor can be affected by these changes and we didn't mostly rely on WPiOS's automated tests for catching any regressions. I'll add this in there.

[guarani]

I think it's safe to ignore Buildkite failures for now (internal references p1621980493008500-slack-CEJT26EG1 , p1623844140451700-slack-CC7L49W13).

Ah yes, I forgot that buildkite errors aren't blockers.

After that one, there was another pass of writing flow test both on WPiOS and WPAndroid mentioned here. That was done on a branch fixing WPAndroid errors targeting RN 0.64 upgrade branch. The changes for the fix were cherry-picked to the RN 0.64 upgrade branch.

Sounds good!

Thanks again! I think that should be enough for now and other than that I guess it would take a lot of time to go through every manual test and we may have to rely on automated ones and the future release tests we'll have.

I think that makes sense.

I thought the regression notes didn't really fit well with a big change like a React Native upgrade it's really hard to tell. I guess the whole Gutenberg editor can be affected by these changes and we didn't mostly rely on WPiOS's automated tests for catching any regressions. I'll add this in there.

Cool, makes sense. I just noticed you added "Gutenberg Mobile has it's own automated tests and doesn't rely on WPiOS's automated tests for now" above. My understanding was that EditorGutenbergTests is relied upon to some extent to catch editor regressions – even though it only really does a little bit of smoke testing of the editor. Not sure if that's what you meant, just wanted to mention it.

Looking forward to using 0.64! 🕺 Thanks for all the work here! 🙇

[ceyhun]

Cool, makes sense. I just noticed you added "Gutenberg Mobile has it's own automated tests and doesn't rely on WPiOS's automated tests for now" above. My understanding was that EditorGutenbergTests is relied upon to some extent to catch editor regressions – even though it only really does a little bit of smoke testing of the editor. Not sure if that's what you meant, just wanted to mention it.

I keep forgetting about that one 😄 But yeah, I guess we'll not be adding any more automated tests other than that for Gutenberg for the time being. Thanks a lot for the review 🙇

[mokagio]

🎉