-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Use react native 0.62 hook for dark mode #21455
Merged
marecar3
merged 3 commits into
rnmobile/update-rn-0-62
from
rnmobile/try/use_rn_0.62_hook_for_dark_mode_ios
Apr 13, 2020
Merged
[iOS] Use react native 0.62 hook for dark mode #21455
marecar3
merged 3 commits into
rnmobile/update-rn-0-62
from
rnmobile/try/use_rn_0.62_hook_for_dark_mode_ios
Apr 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marecar3
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Apr 7, 2020
2 tasks
Size Change: 0 B Total Size: 904 kB ℹ️ View Unchanged
|
…hook_for_dark_mode_ios
gziolo
reviewed
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
etoledom
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marecar3 for this!
It's working great 🎉
Let's get rid of the external dependency 😁
packages/compose/src/hooks/use-preferred-color-scheme/index.ios.js
Outdated
Show resolved
Hide resolved
marecar3
added a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With React Native 0.62 we got built-in dark mode feature: https://reactnative.dev/blog/2020/03/26/version-0.62#new-dark-mode-features
which allows us to remove
react-native-dark-mode
library from the project.Gutenberg mobile PR: wordpress-mobile/gutenberg-mobile#2120
How has this been tested?
The dark mode should work as expected both in the Demo app and the WPiOS app.
Screenshots
Types of changes
Checklist: