Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Native to 0.63 #2580

Closed
wants to merge 32 commits into from
Closed

Upgrade React Native to 0.63 #2580

wants to merge 32 commits into from

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Aug 27, 2020

Upgrade React Native to version 0.63.2

Gutenberg PR: WordPress/gutenberg#24872
WordPress-Android: wordpress-mobile/WordPress-Android#12816
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#14776
react-native-svg PR: wordpress-mobile/react-native-svg#11
react-native-video PR: wordpress-mobile/react-native-video#9
react-native-keyboard-aware-scroll-view PR: wordpress-mobile/react-native-keyboard-aware-scroll-view#11

To test: Gutenberg Editor should work as expected.
Try to run all the manual tests.

Known Issues:

  • On Android demo app cannot type anything to RichText blocks
  • On iOS demo app not possible to dismiss keyboard with the button on top right
  • RN patch in gutenberg needs to be updated (react-native+0.62.2.patch)
  • RN patches in WPiOS needs to be updated (RCTActionSheetManager.patch, etc.)
  • Resolve issue causing Fatal signal 11 (SIGSEGV) crash when running the demo app on Android
  • Triage new Errors and warnings in the RN console log

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 1, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell
Copy link
Contributor

cameronvoell commented Jan 8, 2021

  • Resolve issue causing Fatal signal 11 (SIGSEGV) crash wheb running the demo app on Android
  • Triage new Errors and warnings in the RN console log

Regarding the above, see attached log showing the crash on Android.
2021-01-05-pm-07-31.txt

@ceyhun ceyhun closed this Jul 22, 2021
@ceyhun ceyhun deleted the try/upgrade_to_RN_0.63 branch July 22, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants