Upgrade React Native to 0.63 #14776
Upgrade React Native to 0.63 #14776
Conversation
# Conflicts: # Podfile # Podfile.lock
# Conflicts: # Podfile.lock
# Conflicts: # Podfile.lock
# Conflicts: # Podfile.lock
# Conflicts: # Podfile # Podfile.lock
# Conflicts: # Gemfile.lock # Podfile # Podfile.lock
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
| %x(patch "#{project_root}/Pods/React-CoreModules/RCTActionSheetManager.mm" < "#{project_root}/patches/RN-RCTActionSheetManager.patch") | ||
| puts 'Patching FBReactNativeSpec to add possibility to disable action sheet buttons - | ||
| it could be removed once PR with that functionality will be merged into RN' | ||
| %x(patch "#{project_root}/Pods/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h" < "#{project_root}/patches/FBReactNativeSpec.patch") |
There was a problem hiding this comment.
This might fall too far outside of the scope of what we're trying to take on here (update to RN 0.63) but I wonder if it would be possible to apply the suggested changes from #14240 since we're modifying these patches.
So, instead of using %x(...) can we experiment with replacing that line with system('patch ... < ...') || exit(1). system(...) returns the exit value of the shell so it can help us detecting when the patch fails. But, we should make sure it is not producing false positives and causing the termination of the process unnecessarily.
There was a problem hiding this comment.
I think with the 0.64 upgrade none of these patches here will be necessary anymore. This final remaining patch seems to be merged into 0.64.
Upgrading react-native to version 0.63.2
To test: Follow instructions on gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2580
PR submission checklist:
RELEASE-NOTES.txtif necessary.