Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages: Add missing note about React 17 breaking change #33731

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Packages: Add missing note about React 17 breaking change #33731

merged 1 commit into from
Jul 29, 2021

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jul 28, 2021

Description

Related to #29118.

Partially addresses the issue described by @ocean90 in #24485 (comment):

It looks like the React update wasn't documented in any changelog which means the change in @wordpress/element was released as a minor release while it should have been a major release I think. Now packages like @wordpress/data also require React 17 which doesn't mention that new requirement in the changelog. This is mostly an issue where the packages are used outside of the regular WordPress/Gutenberg context and an upgrade to React 17 isn't possible yet.

I guess it's too late to handle that now but wanted to mention anyway as a reminder for future updates.

The plan is to add a major version bump to all packages that ship React components.

@gziolo gziolo self-assigned this Jul 28, 2021
@gziolo gziolo added npm Packages Related to npm packages [Type] Developer Documentation Documentation for developers labels Jul 28, 2021
@gziolo gziolo mentioned this pull request Jul 28, 2021
Closed
draganescu
draganescu approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for correcting the comment above this PR is a small changelog addition. ✅

@gziolo gziolo force-pushed the update/add-breaking-change-note-react-17 branch from d4869e1 to 9722a3b Compare July 29, 2021 06:05
@gziolo gziolo merged commit ed8a7ad into trunk Jul 29, 2021
@gziolo gziolo deleted the update/add-breaking-change-note-react-17 branch July 29, 2021 06:06
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Jul 29, 2021
gziolo added a commit that referenced this pull request Jul 29, 2021
@gziolo
Packages: Add missing note about React 17 breaking change (#33731)
e6acf11
@talldan talldan modified the milestones: Gutenberg 11.3, Gutenberg 11.2 Aug 4, 2021
@Mamaduka Mamaduka mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@draganescu draganescu draganescu approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@adamziel adamziel Awaiting requested review from adamziel adamziel is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@guarani guarani Awaiting requested review from guarani

@kevin940726 kevin940726 Awaiting requested review from kevin940726 kevin940726 is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@gziolo gziolo

Labels
npm Packages Related to npm packages [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@gziolo @draganescu @swissspidy @talldan