Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add grant privileges to share resource #2447

Merged
merged 9 commits into from
Feb 1, 2024
Merged

feat: Add grant privileges to share resource #2447

merged 9 commits into from
Feb 1, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Jan 30, 2024 •
edited
Loading

Changes

  • Acceptance tests for new resource
  • Unified GrantsOn in GrantPrivilegesToShare + Now user can specify multiple privileges when grating/revoking privileges
  • New resource for granting privileges to share
  • Created a ticket for missing identifier functionality for functions
  • Added documentation for the new resource

Ref: #2417

@github-actions GitHub Actions
Copy link

Integration tests failure for 7592e77def824198a997deb4b2df6c355a0fba5d

@github-actions GitHub Actions
Copy link

Integration tests failure for f34ea5d136c82f184dbaad3397dfb0ac90ee18ac

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the implement-grant-privileges-to-share branch from f34ea5d to af6f2e9 Compare January 30, 2024 14:17
@github-actions GitHub Actions
Copy link

Integration tests failure for af6f2e9a84385ee95be6f8493b3586839673c890

@github-actions GitHub Actions
Copy link

Integration tests failure for 1b41c9cb5711fa5ab56d9a97256c672e51c19cc2

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review January 30, 2024 15:02
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the implement-grant-privileges-to-share branch from f84227e to 7a97d22 Compare January 30, 2024 15:02
@github-actions GitHub Actions
Copy link

Integration tests failure for f84227e22ffac77aae582bbc0c2a3fc6bb5d94d8

@github-actions GitHub Actions
Copy link

Integration tests failure for 7a97d224e7da9b69e8790d4af0d3df8ac1a73f95

sfc-gh-swinkler
sfc-gh-swinkler reviewed Jan 30, 2024
View reviewed changes
docs/resources/grant_privileges_to_share.md Show resolved Hide resolved
docs/resources/grant_privileges_to_share.md Outdated Show resolved Hide resolved
docs/resources/grant_privileges_to_share.md Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
pkg/resources/testdata/TestAcc_GrantPrivilegesToShare/OnAllTablesInSchema/variables.tf Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 31, 2024 08:52
sfc-gh-asawicki
sfc-gh-asawicki requested changes Jan 31, 2024
View reviewed changes
pkg/resources/grant_privileges_to_share_identifier.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
docs/resources/grant_privileges_to_share.md Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_share.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_share_acceptance_test.go Show resolved Hide resolved
pkg/resources/testdata/TestAcc_GrantPrivilegesToShare/OnAllTablesInSchema/variables.tf Show resolved Hide resolved
pkg/sdk/grants_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for ed8bfa5adf4f891356a27e3b6a6cd366eae11c66

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the implement-grant-privileges-to-share branch from ed8bfa5 to d1be669 Compare January 31, 2024 15:51
@github-actions GitHub Actions
Copy link

Integration tests failure for d1be66948f9c3c534661e3154ef4e47f9989f7da

@sfc-gh-swinkler sfc-gh-swinkler mentioned this pull request Feb 1, 2024
Closed
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review February 1, 2024 08:44
sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Feb 1, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Integration tests failure for 7665938ac46057c1487c19e015212f39a87c8e62

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Integration tests failure for 8a74e67b16dc893d8cab47277c97bd0f45c44f6c

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit d8241a5 into main Feb 1, 2024
7 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the implement-grant-privileges-to-share branch February 1, 2024 11:55
@snowflake-release-please snowflake-release-please bot mentioned this pull request Feb 1, 2024
Merged
@KarthikRajashekaran
Copy link

KarthikRajashekaran commented Feb 1, 2024 •
edited
Loading

@sfc-gh-swinkler @sfc-gh-jcieslak
I see it merged to the main , Which version will it be available, and when it will be available

@sfc-gh-jcieslak
Copy link
Collaborator Author

@KarthikRajashekaran in 0.85.0, It should be available today here's the pr for it - #2401

sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 2, 2024
@snowflake-release-please
chore(main): release 0.85.0 (#2401)
ca8ca63 
🤖 I have created a release *beep* *boop*
---


##
[0.85.0](v0.84.1...v0.85.0)
(2024-02-01)


### 🎉 **What's new:**

* Add API integration to the SDK
([#2409](#2409))
([23acda5](23acda5))
* add application to sdk
([#2350](#2350))
([de97ad8](de97ad8))
* add external funcs to sdk
([#2440](#2440))
([c8cf09b](c8cf09b))
* Add grant privileges to share resource
([#2447](#2447))
([d8241a5](d8241a5))
* Add materialized view to the SDK
([#2403](#2403))
([a5ce699](a5ce699))
* Add notification integration to the SDK
([#2412](#2412))
([d84240c](d84240c))
* add sequences to sdk
([#2351](#2351))
([d2e5ffd](d2e5ffd))
* add snowflake grant privileges to account role
([#2365](#2365))
([e3d086e](e3d086e))
* add streamlits to sdk
([#2400](#2400))
([129d24c](129d24c))
* add-call-with to sdk
([#2337](#2337))
([ebcd1bc](ebcd1bc))
* stages migration follow-up
([#2372](#2372))
([3939dbe](3939dbe))
* Use API integration from SDK
([#2429](#2429))
([1ccc864](1ccc864))
* Use managed account from the SDK
([#2420](#2420))
([3aaa080](3aaa080))
* Use materialized views and views from SDK
([#2448](#2448))
([dc66d02](dc66d02))
* Use notification integration from sdk
([#2445](#2445))
([e8915cc](e8915cc))
* use roles from the SDK
([#2405](#2405))
([c645b4d](c645b4d))
* Use row access policy from SDK
([#2428](#2428))
([119af5e](119af5e))
* Use SDK in the storage integration
([#2380](#2380))
([ce0741c](ce0741c))
* use sequence from sdk and add ordering attr
([#2419](#2419))
([973b8f7](973b8f7)),
closes
[#2387](#2387)
* Use stage from sdk
([#2427](#2427))
([c17effd](c17effd))


### 🔧 **Misc**

* add missing deprecation message
([#2451](#2451))
([77de569](77de569))


### 🐛 **Bug fixes:**

* account role test
([#2422](#2422))
([c1b47d1](c1b47d1))
* Adjust tests after Snowflake behavior change
([#2404](#2404))
([8c03ffb](8c03ffb))
* app-pkg unset
([#2399](#2399))
([fedb1df](fedb1df))
* Fix some bugs
([#2421](#2421))
([dec7cd9](dec7cd9)),
closes
[#2358](#2358)
[#2369](#2369)
[#2329](#2329)
* snowflake_grant_privileges_to_role read
([#2424](#2424))
([5385cec](5385cec))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-swinkler sfc-gh-swinkler sfc-gh-swinkler left review comments

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-jcieslak @KarthikRajashekaran @sfc-gh-swinkler @sfc-gh-asawicki