Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use SDK in the storage integration #2380

Merged
merged 8 commits into from
Jan 23, 2024
Merged

feat: Use SDK in the storage integration #2380

merged 8 commits into from
Jan 23, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Jan 19, 2024 •
edited
Loading

  • Replacing the snowflake package with SDK one in the storage integration resource and data source
  • Fixing some of the bugs (incorrect CRUD implementation for some of the attributes / unnecessary checks)
  • Existing tests rewritten with the new framework + added new ones

@github-actions GitHub Actions
Copy link

Integration tests failure for ee94bfccd7597af6d92263c1f2c7dae1ae1401b9

@github-actions GitHub Actions
Copy link

Integration tests failure for 853c6ccc207bf524e9d63df8ced0d49401631b4d

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-sdk-storage-integration branch from 853c6cc to 96b8197 Compare January 22, 2024 09:47
@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review January 22, 2024 09:47
@github-actions GitHub Actions
Copy link

Integration tests failure for 96b81977525aa1c8995c90113bdbf8e5ea3369c6

sfc-gh-asawicki
sfc-gh-asawicki previously approved these changes Jan 22, 2024
View reviewed changes
pkg/resources/helpers_test.go Outdated Show resolved Hide resolved
pkg/resources/storage_integration.go Outdated Show resolved Hide resolved
pkg/resources/storage_integration.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 54bc2d2d1c7e3c768e1b7661f51dcd6cf4342778

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-sdk-storage-integration branch from 1910fe3 to d07f12f Compare January 22, 2024 14:52
@github-actions GitHub Actions
Copy link

Integration tests failure for 1910fe339a1745f3b9dee0c864bb443240349913

@github-actions GitHub Actions
Copy link

Integration tests failure for d07f12f2ca80bd31c3974cc82a9402068a53f9ea

1 similar comment
@github-actions GitHub Actions
Copy link

Integration tests failure for d07f12f2ca80bd31c3974cc82a9402068a53f9ea

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-sdk-storage-integration branch from d07f12f to 2a373ff Compare January 23, 2024 10:07
@sfc-gh-jcieslak sfc-gh-jcieslak merged commit ce0741c into main Jan 23, 2024
3 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the use-sdk-storage-integration branch January 23, 2024 10:08
@github-actions GitHub Actions
Copy link

Integration tests cancelled for 2a373ff11e8f74305ed15ccc2cce115e8ddef3ed

@snowflake-release-please snowflake-release-please bot mentioned this pull request Jan 23, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 2, 2024
@snowflake-release-please
chore(main): release 0.85.0 (#2401)
ca8ca63 
🤖 I have created a release *beep* *boop*
---


##
[0.85.0](v0.84.1...v0.85.0)
(2024-02-01)


### 🎉 **What's new:**

* Add API integration to the SDK
([#2409](#2409))
([23acda5](23acda5))
* add application to sdk
([#2350](#2350))
([de97ad8](de97ad8))
* add external funcs to sdk
([#2440](#2440))
([c8cf09b](c8cf09b))
* Add grant privileges to share resource
([#2447](#2447))
([d8241a5](d8241a5))
* Add materialized view to the SDK
([#2403](#2403))
([a5ce699](a5ce699))
* Add notification integration to the SDK
([#2412](#2412))
([d84240c](d84240c))
* add sequences to sdk
([#2351](#2351))
([d2e5ffd](d2e5ffd))
* add snowflake grant privileges to account role
([#2365](#2365))
([e3d086e](e3d086e))
* add streamlits to sdk
([#2400](#2400))
([129d24c](129d24c))
* add-call-with to sdk
([#2337](#2337))
([ebcd1bc](ebcd1bc))
* stages migration follow-up
([#2372](#2372))
([3939dbe](3939dbe))
* Use API integration from SDK
([#2429](#2429))
([1ccc864](1ccc864))
* Use managed account from the SDK
([#2420](#2420))
([3aaa080](3aaa080))
* Use materialized views and views from SDK
([#2448](#2448))
([dc66d02](dc66d02))
* Use notification integration from sdk
([#2445](#2445))
([e8915cc](e8915cc))
* use roles from the SDK
([#2405](#2405))
([c645b4d](c645b4d))
* Use row access policy from SDK
([#2428](#2428))
([119af5e](119af5e))
* Use SDK in the storage integration
([#2380](#2380))
([ce0741c](ce0741c))
* use sequence from sdk and add ordering attr
([#2419](#2419))
([973b8f7](973b8f7)),
closes
[#2387](#2387)
* Use stage from sdk
([#2427](#2427))
([c17effd](c17effd))


### 🔧 **Misc**

* add missing deprecation message
([#2451](#2451))
([77de569](77de569))


### 🐛 **Bug fixes:**

* account role test
([#2422](#2422))
([c1b47d1](c1b47d1))
* Adjust tests after Snowflake behavior change
([#2404](#2404))
([8c03ffb](8c03ffb))
* app-pkg unset
([#2399](#2399))
([fedb1df](fedb1df))
* Fix some bugs
([#2421](#2421))
([dec7cd9](dec7cd9)),
closes
[#2358](#2358)
[#2369](#2369)
[#2329](#2329)
* snowflake_grant_privileges_to_role read
([#2424](#2424))
([5385cec](5385cec))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-asawicki