Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add-call-with to sdk #2337

Merged
merged 5 commits into from
Jan 25, 2024
Merged

feat: add-call-with to sdk #2337

merged 5 commits into from
Jan 25, 2024

Conversation

sfc-gh-swinkler
Copy link
Collaborator

adds call and call-with to procedures.

https://docs.snowflake.com/en/sql-reference/sql/call
https://docs.snowflake.com/en/sql-reference/sql/call-with

this was tricky to do, so was not added to original PR. will be useful in the future, for making a data source that could invoke the call function. similar to the AWS invoke lamba data source. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_invocation

Copy link

Integration tests failure for e6278d609d89f37802200d34c4b6f2d46d6ab1a9

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review January 17, 2024 10:25
pkg/sdk/procedures_def.go Outdated Show resolved Hide resolved
pkg/sdk/procedures_impl_gen.go Outdated Show resolved Hide resolved
pkg/sdk/procedures_gen.go Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Outdated Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Outdated Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Show resolved Hide resolved
pkg/sdk/procedures_validations_gen.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 995653b755911b583e758d61329863826f42b5b3

Copy link

Integration tests failure for 079bc6e62b49fbaa0750061b4e8e242999fa9dcd

Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but please wait for @sfc-gh-jcieslak re-review also.

Copy link

Integration tests failure for f4d77a8daa3a1600b3c9082ec550f0ea2e274666

@sfc-gh-swinkler sfc-gh-swinkler merged commit ebcd1bc into main Jan 25, 2024
5 of 7 checks passed
@sfc-gh-swinkler sfc-gh-swinkler deleted the call-with branch January 25, 2024 05:24
Copy link

Integration tests failure for d4ab1be355933eaa1ab9b258db505b8cda0989f2

sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.85.0](v0.84.1...v0.85.0)
(2024-02-01)


### 🎉 **What's new:**

* Add API integration to the SDK
([#2409](#2409))
([23acda5](23acda5))
* add application to sdk
([#2350](#2350))
([de97ad8](de97ad8))
* add external funcs to sdk
([#2440](#2440))
([c8cf09b](c8cf09b))
* Add grant privileges to share resource
([#2447](#2447))
([d8241a5](d8241a5))
* Add materialized view to the SDK
([#2403](#2403))
([a5ce699](a5ce699))
* Add notification integration to the SDK
([#2412](#2412))
([d84240c](d84240c))
* add sequences to sdk
([#2351](#2351))
([d2e5ffd](d2e5ffd))
* add snowflake grant privileges to account role
([#2365](#2365))
([e3d086e](e3d086e))
* add streamlits to sdk
([#2400](#2400))
([129d24c](129d24c))
* add-call-with to sdk
([#2337](#2337))
([ebcd1bc](ebcd1bc))
* stages migration follow-up
([#2372](#2372))
([3939dbe](3939dbe))
* Use API integration from SDK
([#2429](#2429))
([1ccc864](1ccc864))
* Use managed account from the SDK
([#2420](#2420))
([3aaa080](3aaa080))
* Use materialized views and views from SDK
([#2448](#2448))
([dc66d02](dc66d02))
* Use notification integration from sdk
([#2445](#2445))
([e8915cc](e8915cc))
* use roles from the SDK
([#2405](#2405))
([c645b4d](c645b4d))
* Use row access policy from SDK
([#2428](#2428))
([119af5e](119af5e))
* Use SDK in the storage integration
([#2380](#2380))
([ce0741c](ce0741c))
* use sequence from sdk and add ordering attr
([#2419](#2419))
([973b8f7](973b8f7)),
closes
[#2387](#2387)
* Use stage from sdk
([#2427](#2427))
([c17effd](c17effd))


### 🔧 **Misc**

* add missing deprecation message
([#2451](#2451))
([77de569](77de569))


### 🐛 **Bug fixes:**

* account role test
([#2422](#2422))
([c1b47d1](c1b47d1))
* Adjust tests after Snowflake behavior change
([#2404](#2404))
([8c03ffb](8c03ffb))
* app-pkg unset
([#2399](#2399))
([fedb1df](fedb1df))
* Fix some bugs
([#2421](#2421))
([dec7cd9](dec7cd9)),
closes
[#2358](#2358)
[#2369](#2369)
[#2329](#2329)
* snowflake_grant_privileges_to_role read
([#2424](#2424))
([5385cec](5385cec))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants