feat: Use stage from sdk #2427
feat: Use stage from sdk #2427
Conversation
|
Integration tests failure for 8e8c6a95b91abc213b9d99d6050600d34832d986 |
|
Integration tests failure for 61a537c5ed306c5f4c0ced6e2afad19d531aa50c |
|
Integration tests failure for a913e63e0981a84dd61cfbf23a50d25e65a429c2 |
| @@ -56,42 +57,55 @@ var stagesSchema = map[string]*schema.Schema{ | |||
|
|
|||
| func Stages() *schema.Resource { | |||
| return &schema.Resource{ | |||
| Read: ReadStages, | |||
| Schema: stagesSchema, | |||
| ReadContext: ReadStages, | |||
There was a problem hiding this comment.
i didnt know about this ReadContext function. we could actually use this for all resources, as we are using context.Background()
There was a problem hiding this comment.
Yeah, this is one of the points I added to our discussion on our resource-designing conventions. I'm using it because Read is deprecated and ReadContext or ReadWithoutTimeout should be used instead.
| tagChangeErr := handleTagChanges(db, d, builder) | ||
| if tagChangeErr != nil { | ||
| return tagChangeErr | ||
| if d.HasChange("tag") { |
There was a problem hiding this comment.
is there a reason for moving the tag diff logic here?
There was a problem hiding this comment.
So, tags were one of the things I could change in the Update method, so I did it. handleTagChanges is the old implementation using the snowflake package.
|
Integration tests failure for 616c153060eee92d252a9e83331bd5e8b2f1822b |
|
Integration tests failure for 616c153060eee92d252a9e83331bd5e8b2f1822b |
1 similar comment
|
Integration tests failure for 616c153060eee92d252a9e83331bd5e8b2f1822b |
|
Integration tests failure for a7745896804c667ef738f81ee4925565ad176d55 |
🤖 I have created a release *beep* *boop* --- ## [0.85.0](v0.84.1...v0.85.0) (2024-02-01) ### 🎉 **What's new:** * Add API integration to the SDK ([#2409](#2409)) ([23acda5](23acda5)) * add application to sdk ([#2350](#2350)) ([de97ad8](de97ad8)) * add external funcs to sdk ([#2440](#2440)) ([c8cf09b](c8cf09b)) * Add grant privileges to share resource ([#2447](#2447)) ([d8241a5](d8241a5)) * Add materialized view to the SDK ([#2403](#2403)) ([a5ce699](a5ce699)) * Add notification integration to the SDK ([#2412](#2412)) ([d84240c](d84240c)) * add sequences to sdk ([#2351](#2351)) ([d2e5ffd](d2e5ffd)) * add snowflake grant privileges to account role ([#2365](#2365)) ([e3d086e](e3d086e)) * add streamlits to sdk ([#2400](#2400)) ([129d24c](129d24c)) * add-call-with to sdk ([#2337](#2337)) ([ebcd1bc](ebcd1bc)) * stages migration follow-up ([#2372](#2372)) ([3939dbe](3939dbe)) * Use API integration from SDK ([#2429](#2429)) ([1ccc864](1ccc864)) * Use managed account from the SDK ([#2420](#2420)) ([3aaa080](3aaa080)) * Use materialized views and views from SDK ([#2448](#2448)) ([dc66d02](dc66d02)) * Use notification integration from sdk ([#2445](#2445)) ([e8915cc](e8915cc)) * use roles from the SDK ([#2405](#2405)) ([c645b4d](c645b4d)) * Use row access policy from SDK ([#2428](#2428)) ([119af5e](119af5e)) * Use SDK in the storage integration ([#2380](#2380)) ([ce0741c](ce0741c)) * use sequence from sdk and add ordering attr ([#2419](#2419)) ([973b8f7](973b8f7)), closes [#2387](#2387) * Use stage from sdk ([#2427](#2427)) ([c17effd](c17effd)) ### 🔧 **Misc** * add missing deprecation message ([#2451](#2451)) ([77de569](77de569)) ### 🐛 **Bug fixes:** * account role test ([#2422](#2422)) ([c1b47d1](c1b47d1)) * Adjust tests after Snowflake behavior change ([#2404](#2404)) ([8c03ffb](8c03ffb)) * app-pkg unset ([#2399](#2399)) ([fedb1df](fedb1df)) * Fix some bugs ([#2421](#2421)) ([dec7cd9](dec7cd9)), closes [#2358](#2358) [#2369](#2369) [#2329](#2329) * snowflake_grant_privileges_to_role read ([#2424](#2424)) ([5385cec](5385cec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Changes: