feat: Add materialized view to the SDK #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 2a4cd70bbd8f4fe32115099167e5b44cf44755f6 |
1 similar comment
|
Integration tests failure for 2a4cd70bbd8f4fe32115099167e5b44cf44755f6 |
sfc-gh-asawicki
force-pushed
the
add-materialized-view-to-the-sdk
branch
from
2a4cd70 to
a1e3fba
Compare
|
Integration tests failure for a1e3fba83c7fd59f0dd8f235f92ca008a6da6bd9 |
1 similar comment
|
Integration tests failure for a1e3fba83c7fd59f0dd8f235f92ca008a6da6bd9 |
|
|
||
| var materializedViewColumn = g.NewQueryStruct("MaterializedViewColumn"). | ||
| Text("Name", g.KeywordOptions().DoubleQuotes().Required()). | ||
| OptionalTextAssignment("COMMENT", g.ParameterOptions().SingleQuotes().NoEquals()) |
There was a problem hiding this comment.
does column actually allow comment? im having trouble finding it in the docs
There was a problem hiding this comment.
I will add this to the questions about the docs I post on doc-discuss.
You are right. It's not written in materialized view docs but in regular view ones. Also, there is a test proving that it can be done: https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/2403/files#diff-7a8a3cc00d490b622d152a5bdf42e0915fff497c2eb4554f491dfaaaa3d51025R124.
sfc-gh-jcieslak
approved these changes
Jan 24, 2024
|
Integration tests failure for c552d5f54bce484a4496aa7ac12575d49ba46fdf |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.85.0](v0.84.1...v0.85.0) (2024-02-01) ### 🎉 **What's new:** * Add API integration to the SDK ([#2409](#2409)) ([23acda5](23acda5)) * add application to sdk ([#2350](#2350)) ([de97ad8](de97ad8)) * add external funcs to sdk ([#2440](#2440)) ([c8cf09b](c8cf09b)) * Add grant privileges to share resource ([#2447](#2447)) ([d8241a5](d8241a5)) * Add materialized view to the SDK ([#2403](#2403)) ([a5ce699](a5ce699)) * Add notification integration to the SDK ([#2412](#2412)) ([d84240c](d84240c)) * add sequences to sdk ([#2351](#2351)) ([d2e5ffd](d2e5ffd)) * add snowflake grant privileges to account role ([#2365](#2365)) ([e3d086e](e3d086e)) * add streamlits to sdk ([#2400](#2400)) ([129d24c](129d24c)) * add-call-with to sdk ([#2337](#2337)) ([ebcd1bc](ebcd1bc)) * stages migration follow-up ([#2372](#2372)) ([3939dbe](3939dbe)) * Use API integration from SDK ([#2429](#2429)) ([1ccc864](1ccc864)) * Use managed account from the SDK ([#2420](#2420)) ([3aaa080](3aaa080)) * Use materialized views and views from SDK ([#2448](#2448)) ([dc66d02](dc66d02)) * Use notification integration from sdk ([#2445](#2445)) ([e8915cc](e8915cc)) * use roles from the SDK ([#2405](#2405)) ([c645b4d](c645b4d)) * Use row access policy from SDK ([#2428](#2428)) ([119af5e](119af5e)) * Use SDK in the storage integration ([#2380](#2380)) ([ce0741c](ce0741c)) * use sequence from sdk and add ordering attr ([#2419](#2419)) ([973b8f7](973b8f7)), closes [#2387](#2387) * Use stage from sdk ([#2427](#2427)) ([c17effd](c17effd)) ### 🔧 **Misc** * add missing deprecation message ([#2451](#2451)) ([77de569](77de569)) ### 🐛 **Bug fixes:** * account role test ([#2422](#2422)) ([c1b47d1](c1b47d1)) * Adjust tests after Snowflake behavior change ([#2404](#2404)) ([8c03ffb](8c03ffb)) * app-pkg unset ([#2399](#2399)) ([fedb1df](fedb1df)) * Fix some bugs ([#2421](#2421)) ([dec7cd9](dec7cd9)), closes [#2358](#2358) [#2369](#2369) [#2329](#2329) * snowflake_grant_privileges_to_role read ([#2424](#2424)) ([5385cec](5385cec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add materialized view to the SDK
Differences with the docs (I will add them on doc-discuss):