72 main nav #264

yvonnetangsu · 2018-11-02T22:27:44Z

READY FOR REVIEW

Summary

Create Main site navigation component

Needed By (Date)

ASAP - Event calendar is already using this

Urgency

Event calendar is already using this

Steps to Test

Pull this branch
Run grunt styleguide
Check that the main nav behaves as specified in the Figma document

Affected Projects or Products

Decanter

Associated Issues and/or People

Create main navigation component (twig & sass) #72

…icky

* master: reversed order of modular scale type mixin (#260) 122 hero (#259) 195 added all Stanford approved fonts (#248) change class for logo to match new naming conventions. (#257) px to rem (#256) 219 Modular typography (#250) fixup! wip. (#255) 79 card (#241) make color change on hover & focus less abrupt (#253)

Co-Authored-By: sherakama <[email protected]>

core/scss/components/main-nav/_main-nav.scss

* master: 189 Alert Component (#263) 216 Create site search component (#262) 266: Update scss file to reference logo.twig and update twig file to … (#267) 246 homepage (#258)

sherakama · 2019-03-05T22:33:59Z

I've created a ticket so we can go over the .eslintrc file's settings: #308

For the sake of this PR, I am going to format based off what is there today.

sherakama · 2019-03-05T23:29:42Z

@yvonnetangsu @JBCSU
HUGE PROPS to the no javascript fallback. I think you have created one of, if not the, most accessible main navigations in higher ED and elsewhere.

sherakama · 2019-03-05T23:39:38Z

core/templates/components/main-nav/main-nav.twig

+<script>
+  // Do this immediately to minimize FOUC.
+  NodeList.prototype.forEach = NodeList.prototype.forEach || Array.prototype.forEach;
+  document.querySelectorAll('nav.su-main-nav').forEach(nav => { nav.classList.remove('no-js'); } );


This gets fired off 5 times in the styleguide. Each time the nav is rendered this code gets introduced. This also collectively picks up a nav each time it runs. I suppose that isn't harmful but does have me itching for an optimization. Good for now.

sherakama · 2019-03-05T23:42:45Z

core/templates/components/main-nav/main-nav.twig

+    {% endif %}
+    {% endspaceless %}
+  </ul>
+  {% if "su-main-nav--mobile-search" in modifier_class %}


One thought came to mind with this and how we expect it to interact with the full desktop search. Just two forms? Hide the other on mobile?

Yeah, that's what I was thinking but there might be better solutions. Perhaps we could think about this some more when we build the masthead component? 😃

sherakama

GTG

Thank you for the huge lift. I think this nav exceeds our expectations and is ready to be merged in to the main project.

yvonnetangsu · 2019-03-06T00:05:56Z

GTG

Thank you for the huge lift. I think this nav exceeds our expectations and is ready to be merged in to the main project.

Thank you for reviewing and the cc fixes! There are minor tweaks I'd like to do (eg, turn this into a mixin so we can pass color parameters to @fancy-hover) but happy to get this merged first 😸

sherakama · 2019-03-06T00:07:04Z

Yep, there will be revisions. There always is. This is in a very good place at the moment.

josephgknox

+1 to all of the wonderful things Shea said here. You two deserve huge props for this work. Really excited to see this get merged in.

yvonnetangsu · 2019-03-06T00:21:09Z

Awesome!! Thank you to you both for the useful suggestions and reviewing along the way! Now I'm going to squash and merge before you change your mind 😁 😁

* master: 72 main nav (#264)

* master: Tweaking modular-spacing mixin to be more user friendly (#309) 120 Skiplinks (#303) 72 main nav (#264)

* master: Add linear gradient background mixin (#304) Tweaking modular-spacing mixin to be more user friendly (#309) 120 Skiplinks (#303) 72 main nav (#264) Update _input.scss (#301) Update README.md (#302) 298-change "sticky-footer" mixin to target <footer> selector (#299) Set base font size for each breakpoint (#295) doc: add period (#294) 151 global footer tweaks (#293) Small bugfix for mobile. (#291) 282: Fix modular-spacing mixins and variables (#290) # Conflicts: # core/js/decanter.js - moved code into core/js/components/main-nav/main-nav.js

yvonnetangsu and others added 10 commits November 2, 2018 00:26

72: first pass of setting up main nav

97f9f36

Merge branch '246-homepage' into 202-sticky

4116532

Merge branch 'master' of github.com:SU-SWS/decanter into 246-homepage

fd5510a

fixup! wip.

4ca3a38

fixup! wip.

2bb7cfe

Sticky footer mixin.

51b1b9e

Merge branch '246-homepage' of github.com:SU-SWS/decanter into 202-st…

56ee82b

…icky

Sticky footer mixin.

dd4c3c7

72: fixup

f247814

yvonnetangsu self-assigned this Nov 2, 2018

JBCSU and others added 3 commits November 2, 2018 15:29

Update core/scss/utilities/mixins/layout/_sticky-footer.scss

7702e1f

Co-Authored-By: sherakama <[email protected]>

Update core/scss/utilities/mixins/layout/_sticky-footer.scss

d9296af

Co-Authored-By: sherakama <[email protected]>

Update core/scss/utilities/mixins/layout/_sticky-footer.scss

c8576e4

Co-Authored-By: sherakama <[email protected]>

sherakama reviewed Nov 4, 2018

View reviewed changes

core/scss/components/main-nav/_main-nav.scss Outdated Show resolved Hide resolved

sherakama reviewed Nov 4, 2018

View reviewed changes

core/scss/components/main-nav/_main-nav.scss Outdated Show resolved Hide resolved

sherakama reviewed Nov 4, 2018

View reviewed changes

core/scss/components/main-nav/_main-nav.scss Outdated Show resolved Hide resolved

sherakama and others added 13 commits November 8, 2018 14:31

New grid stuff.

8c63bf7

Merge branch 'master' into 72-main-nav

cbd5dbf

* master: 189 Alert Component (#263) 216 Create site search component (#262) 266: Update scss file to reference logo.twig and update twig file to … (#267) 246 homepage (#258)

Sort of refactored.

b5ccbb8

Layout - Bricks

0b97f4b

Layout - Basic

20c3e0b

Layout - Battleship.

6879fcc

72: put fancy-hover into own mixin file

b251912

Layout - Blastila.

5f5afac

Layout - Frogger.

2dc79b0

Layout - Pacman.

3433c3c

Layout - Plakes.

aa4066e

Layout - Wedge.

40dbd8d

Remove three-column layout from Richard.

68ec671

sherakama added 2 commits March 5, 2019 14:21

fixup! cc.

882de5e

fixup! cc.

a6fa631

sherakama added 9 commits March 5, 2019 14:51

fixup! cc.

23052c5

fixup! cc.

754ee7b

fixup! cc.

5456683

fixup! cc.

093f16b

fixup! cc.

3692496

fixup! cc.

b26f3c2

fixup! cc.

b176645

fixup! cc.

7c3ecc1

fixup! cc.

b983d60

Update main-nav.twig

793a007

sherakama reviewed Mar 5, 2019

View reviewed changes

Update main-nav.twig

9b3cbdf

sherakama reviewed Mar 5, 2019

View reviewed changes

sherakama approved these changes Mar 5, 2019

View reviewed changes

sherakama requested a review from josephgknox March 5, 2019 23:55

sherakama added the enhancement label Mar 5, 2019

josephgknox approved these changes Mar 6, 2019

View reviewed changes

yvonnetangsu merged commit 33d92a7 into master Mar 6, 2019

sherakama deleted the 72-main-nav branch March 6, 2019 01:00

yvonnetangsu added a commit that referenced this pull request Mar 6, 2019

Merge branch 'master' into modular-spacing-tweak-b

5abf6ea

* master: 72 main nav (#264)

yvonnetangsu added a commit that referenced this pull request Mar 6, 2019

Merge branch 'master' into gradient-mixin

38be28a

* master: Tweaking modular-spacing mixin to be more user friendly (#309) 120 Skiplinks (#303) 72 main nav (#264)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

72 main nav #264

72 main nav #264

yvonnetangsu commented Nov 2, 2018 •

edited by JBCSU

Loading

sherakama commented Mar 5, 2019

sherakama commented Mar 5, 2019

sherakama Mar 5, 2019

sherakama Mar 5, 2019

yvonnetangsu Mar 6, 2019

sherakama left a comment

yvonnetangsu commented Mar 6, 2019

sherakama commented Mar 6, 2019

josephgknox left a comment

yvonnetangsu commented Mar 6, 2019

72 main nav #264

72 main nav #264

Conversation

yvonnetangsu commented Nov 2, 2018 • edited by JBCSU Loading

READY FOR REVIEW

Summary

Needed By (Date)

Urgency

Steps to Test

Affected Projects or Products

Associated Issues and/or People

sherakama commented Mar 5, 2019

sherakama commented Mar 5, 2019

sherakama Mar 5, 2019

Choose a reason for hiding this comment

sherakama Mar 5, 2019

Choose a reason for hiding this comment

yvonnetangsu Mar 6, 2019

Choose a reason for hiding this comment

sherakama left a comment

Choose a reason for hiding this comment

yvonnetangsu commented Mar 6, 2019

sherakama commented Mar 6, 2019

josephgknox left a comment

Choose a reason for hiding this comment

yvonnetangsu commented Mar 6, 2019

yvonnetangsu commented Nov 2, 2018 •

edited by JBCSU

Loading