151 global footer tweaks #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stocker two formatting items to get to: https://codeclimate.com/github/SU-SWS/decanter/pull/293 |
sherakama
approved these changes
Feb 14, 2019
josephgknox
approved these changes
Feb 14, 2019
yvonnetangsu
requested changes
Feb 14, 2019
|
Btw, @sherakama @josephgknox , I sneaked in the a:focus/outline change (removing the outline:0) in with this PR - let us know if that's ok. If not, I'll take it out. |
Co-Authored-By: stocker <[email protected]>
|
@yvonnetangsu totally OK! Thanks for doing that. |
Co-Authored-By: stocker <[email protected]>
|
@stocker woot! Thanks for cleaning those up. |
|
Woot. Thanks all. |
JBCSU
added a commit
that referenced
this pull request
Mar 7, 2019
* master: Add linear gradient background mixin (#304) Tweaking modular-spacing mixin to be more user friendly (#309) 120 Skiplinks (#303) 72 main nav (#264) Update _input.scss (#301) Update README.md (#302) 298-change "sticky-footer" mixin to target <footer> selector (#299) Set base font size for each breakpoint (#295) doc: add period (#294) 151 global footer tweaks (#293) Small bugfix for mobile. (#291) 282: Fix modular-spacing mixins and variables (#290) # Conflicts: # core/js/decanter.js - moved code into core/js/components/main-nav/main-nav.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People