Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set base font size for each breakpoint #295

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Set base font size for each breakpoint #295

merged 3 commits into from
Feb 21, 2019

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Feb 21, 2019 •
edited
Loading

READY FOR REVIEW

Summary

  • A small PR - Just setting the base font size at each breakpoint as described in Figma doc so we can use em values properly in other places.

Needed By (Date)

  • N/A

Urgency

  • Not urgent

Steps to Test

  1. Pull this branch and run grunt styleguide
  2. Check that <body> has the correct base font size at each breakpoint.

Affected Projects or Products

  • Decanter

Associated Issues and/or People

  • Might affect other components/elements and the styleguide itself that uses "em" values.
  • JB is still working on the other modular-typography related mixins (eg, display-a) so those will come later.

@yvonnetangsu
Copy link
Member Author

screen shot 2019-02-21 at 3 26 18 pm

josephgknox
josephgknox approved these changes Feb 21, 2019
View reviewed changes
Copy link

@josephgknox josephgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for getting this in.

@sherakama sherakama merged commit 403d237 into master Feb 21, 2019
@sherakama sherakama deleted the base-font-size branch February 21, 2019 23:53
JBCSU added a commit that referenced this pull request Mar 7, 2019
@JBCSU
Merge branch 'master' into 90-basic-webpack
915c4b1 
* master:
  Add linear gradient background mixin (#304)
  Tweaking modular-spacing mixin to be more user friendly (#309)
  120 Skiplinks (#303)
  72 main nav (#264)
  Update _input.scss (#301)
  Update README.md (#302)
  298-change "sticky-footer" mixin to target <footer> selector  (#299)
  Set base font size for each breakpoint (#295)
  doc: add period (#294)
  151 global footer tweaks (#293)
  Small bugfix for mobile. (#291)
  282: Fix modular-spacing mixins and variables (#290)

# Conflicts:
#	core/js/decanter.js - moved code into core/js/components/main-nav/main-nav.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephgknox josephgknox josephgknox approved these changes

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvonnetangsu @sherakama @josephgknox