Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _input.scss #301

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Update _input.scss #301

merged 1 commit into from
Feb 28, 2019

Conversation

sherakama
Copy link
Member

READY FOR REVIEW

Summary

  • Fixes code climate complaints.

Needed By (Date)

  • Whenever

Urgency

  • none

Steps to Test

  1. Compile code
  2. Review styleguide output

See Also

@sherakama
Update _input.scss
a79db57 
Fixes code climate complaints.
josephgknox
josephgknox approved these changes Feb 28, 2019
View reviewed changes
Copy link

@josephgknox josephgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that.

@josephgknox josephgknox merged commit 9a36620 into master Feb 28, 2019
@josephgknox josephgknox deleted the codeclimate-input branch February 28, 2019 19:45
yvonnetangsu added a commit that referenced this pull request Mar 1, 2019
@yvonnetangsu
Merge branch 'master' into gradient-mixin
1ccde01 
* master:
  Update _input.scss (#301)
  Update README.md (#302)
yvonnetangsu added a commit that referenced this pull request Mar 5, 2019
@yvonnetangsu
Merge branch 'master' into 72-main-nav
232c17b 
* master:
  Update _input.scss (#301)
  Update README.md (#302)
  298-change "sticky-footer" mixin to target <footer> selector  (#299)
JBCSU added a commit that referenced this pull request Mar 7, 2019
@JBCSU
Merge branch 'master' into 90-basic-webpack
915c4b1 
* master:
  Add linear gradient background mixin (#304)
  Tweaking modular-spacing mixin to be more user friendly (#309)
  120 Skiplinks (#303)
  72 main nav (#264)
  Update _input.scss (#301)
  Update README.md (#302)
  298-change "sticky-footer" mixin to target <footer> selector  (#299)
  Set base font size for each breakpoint (#295)
  doc: add period (#294)
  151 global footer tweaks (#293)
  Small bugfix for mobile. (#291)
  282: Fix modular-spacing mixins and variables (#290)

# Conflicts:
#	core/js/decanter.js - moved code into core/js/components/main-nav/main-nav.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu approved these changes

@josephgknox josephgknox josephgknox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherakama @josephgknox @yvonnetangsu