-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
246 homepage #258
Merged
Merged
246 homepage #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephgknox
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made several tweaks to get this to a strong MVP IMO.
@sherakama whatcha think? |
yvonnetangsu
added a commit
that referenced
this pull request
Nov 7, 2018
* master: 216 Create site search component (#262) 266: Update scss file to reference logo.twig and update twig file to … (#267) 246 homepage (#258) reversed order of modular scale type mixin (#260) 122 hero (#259) 195 added all Stanford approved fonts (#248) change class for logo to match new naming conventions. (#257) px to rem (#256) 219 Modular typography (#250) fixup! wip. (#255) 79 card (#241) make color change on hover & focus less abrupt (#253) 249: Change CTA icon to a variable (#251) 223 brand bar (#243) # Conflicts: # core/css/decanter.css # core/scss/components/index.scss # core/templates/components/logo/logo.twig
yvonnetangsu
added a commit
that referenced
this pull request
Nov 9, 2018
JBCSU
added a commit
that referenced
this pull request
Nov 9, 2018
* master: 89 browsersync (#272) 189 Alert Component (#263) 216 Create site search component (#262) 266: Update scss file to reference logo.twig and update twig file to … (#267) 246 homepage (#258) reversed order of modular scale type mixin (#260) 122 hero (#259) # Conflicts: - all resolved using master # core/scss/homepage.md # kss/builder/decanter/index.twig # kss/builder/decanter/kss-assets/css/kss.css # kss/builder/decanter/scss/_home.scss # kss/builder/decanter/scss/kss.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not Ready