189 Alert Component #263
Merged
189 Alert Component #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherakama
reviewed
Nov 5, 2018
sherakama
approved these changes
Nov 7, 2018
yvonnetangsu
reviewed
Nov 7, 2018
| // | ||
| // Markup: ../templates/components/alert/alert.twig | ||
| // | ||
| // Style guide: Components.Alert | ||
| // | ||
| .su-alert { | ||
| @include alerts; | ||
| } | ||
| @include margin(1.5em null null); |
There was a problem hiding this comment.
I only have one question - is there a reason to add a top margin for this component? We don't have margins for cards or hero block for example. Everything else looks great to me!
There was a problem hiding this comment.
Oh good catch!
@josephgknox What gives?
There was a problem hiding this comment.
Just keeping you both on your toes. :)
Really, this shouldn't be there, as this type of spacing/margin should be applied more globally (theme level, project level, etc.) rather than on an individual component.
Thanks for catching this. I've pushed up a fix.
yvonnetangsu
added a commit
that referenced
this pull request
Nov 9, 2018
JBCSU
added a commit
that referenced
this pull request
Nov 9, 2018
* master: 89 browsersync (#272) 189 Alert Component (#263) 216 Create site search component (#262) 266: Update scss file to reference logo.twig and update twig file to … (#267) 246 homepage (#258) reversed order of modular scale type mixin (#260) 122 hero (#259) # Conflicts: - all resolved using master # core/scss/homepage.md # kss/builder/decanter/index.twig # kss/builder/decanter/kss-assets/css/kss.css # kss/builder/decanter/scss/_home.scss # kss/builder/decanter/scss/kss.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
Affected Projects or Products
Associated Issues and/or People
See Also