Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 3.2.0-beta.1 #1716

Merged
merged 1 commit into from
Jun 19, 2018
Merged

chore(release): 3.2.0-beta.1 #1716

merged 1 commit into from
Jun 19, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 18, 2018 •
edited
Loading

overview

This PR bumps to 3.2.0-beta.1

changelog

Bug Fixes

  • api: Add ignore update endpoint implementation to fallback file (#1720) (2a68dc5)
  • api: Fix RPC reporting wrong models for v1.3 pipettes (#1691) (e302382)
  • api: Fixes bug in replacing substring of old p50 pipettes written with v13 instead of v1.3 (#1717) (1322055)
  • app: Enable robot update even if API reports up-to-date (#1721) (16bb8eb)
  • app: Fix alignment issues in modals, fix titlebar on page (#1719) (ccf4881)
  • app: Switch to hash routes to enable goBack in prod (#1722) (9bf2398)
  • protocol-designer: fix styles for SelectionRect (#1714) (295940e)

Features

review requests

Standard release testing please

@mcous mcous added chore ready for review DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available and removed ready for review labels Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018 •
edited
Loading

Codecov Report

Merging #1716 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           edge   #1716   +/-   ##
====================================
  Coverage    35%     35%           
====================================
  Files       344     344           
  Lines      5648    5648           
====================================
  Hits       1977    1977           
  Misses     3671    3671

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf2398...1f08d62. Read the comment docs.

IanLondon
IanLondon previously approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥗

@mcous mcous force-pushed the release_3.2.0-beta.1 branch from ed071cc to 24e8ac8 Compare June 18, 2018 21:06
@mcous mcous dismissed IanLondon’s stale review June 18, 2018 21:06

Dismissing due to rebase

btmorr
btmorr approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@btmorr btmorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gotten to test on a robot, but the changes included in this release all look sane

@mcous mcous added ready for review and removed DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available labels Jun 18, 2018
IanLondon
IanLondon approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥗 🥗

@mcous mcous added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jun 19, 2018
@mcous mcous force-pushed the release_3.2.0-beta.1 branch from 24e8ac8 to b603f48 Compare June 19, 2018 16:01
@mcous mcous removed the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jun 19, 2018
Kadee80
Kadee80 approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇦🇺 🐨 ⚽️ tested on sunset 🌆

@mcous mcous force-pushed the release_3.2.0-beta.1 branch from b603f48 to 1f08d62 Compare June 19, 2018 17:32
Laura-Danielle
Laura-Danielle approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@mcous mcous merged commit ce86ff6 into edge Jun 19, 2018
@mcous mcous deleted the release_3.2.0-beta.1 branch June 19, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laura-Danielle Laura-Danielle Laura-Danielle approved these changes

@IanLondon IanLondon IanLondon approved these changes

@btmorr btmorr btmorr approved these changes

@Kadee80 Kadee80 Kadee80 approved these changes

@umbhau umbhau Awaiting requested review from umbhau

@andySigler andySigler Awaiting requested review from andySigler

@b-cooper b-cooper Awaiting requested review from b-cooper

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
5 participants
@mcous @Kadee80 @btmorr @IanLondon @Laura-Danielle