feat(app): Show connect alert banner on successful connection #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kadee80
added
feature
mcous
approved these changes
Jun 14, 2018
| @@ -58,6 +59,7 @@ function RobotSettingsPage (props: Props) { | |||
| return ( | |||
| <Page> | |||
| <TitleBar title={robot.name} /> | |||
| <ConnectBanner {...robot} key={Number(robot.isConnected)}/> | |||
There was a problem hiding this comment.
What's the purpose of Number here?
There was a problem hiding this comment.
Flow was expected number or string not a bool
| const TITLE = `${name} successfully connected` | ||
| return ( | ||
| <div> | ||
| {isVisible && ( |
There was a problem hiding this comment.
Could also do an early null return if !isVisible
There was a problem hiding this comment.
i like that. will change in a bit
Codecov Report
@@ Coverage Diff @@
## edge #1700 +/- ##
==========================================
- Coverage 34.68% 34.57% -0.12%
==========================================
Files 342 343 +1
Lines 5576 5594 +18
==========================================
Hits 1934 1934
- Misses 3642 3660 +18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR closes #1314. Will open a separate issue for connectRequest error banner.
changelog
review requests